Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PR] Adding env variables to deploy workflow so compile_env works. #102

Merged
merged 11 commits into from
Jul 19, 2023
Merged

[PR] Adding env variables to deploy workflow so compile_env works. #102

merged 11 commits into from
Jul 19, 2023

Conversation

LuchoTurtle
Copy link
Member

This should solve the issue where compile_env variables used in the code are not being properly initialized when building and deploying to fly.io.

@LuchoTurtle LuchoTurtle added bug Suspected or confirmed bug (defect) in the code in-progress An issue or pull request that is being worked on by the assigned person labels Jul 19, 2023
@LuchoTurtle LuchoTurtle self-assigned this Jul 19, 2023
nelsonic
nelsonic reviewed Jul 19, 2023
View reviewed changes
lib/app/upload.ex Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Jul 19, 2023 •
edited
Loading

Codecov Report

Merging #102 (7babb19) into main (66a8e0f) will not change coverage.
The diff coverage is 100.00%.

❗ Current head 7babb19 differs from pull request most recent head 98c394e. Consider uploading reports for the commit 98c394e to get more accurate results

@@            Coverage Diff            @@
##              main      #102   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            7         8    +1     
  Lines           95       128   +33     
=========================================
+ Hits            95       128   +33
Impacted Files Coverage Δ
lib/app/upload.ex 100.00% <100.00%> (ø)

... and 3 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@LuchoTurtle
Copy link
Member Author

image

Seems to be working now 👌

@LuchoTurtle LuchoTurtle mentioned this pull request Jul 19, 2023
Closed
@LuchoTurtle LuchoTurtle assigned nelsonic and unassigned LuchoTurtle Jul 19, 2023
@LuchoTurtle LuchoTurtle added awaiting-review An issue or pull request that needs to be reviewed and removed in-progress An issue or pull request that is being worked on by the assigned person labels Jul 19, 2023
nelsonic
nelsonic reviewed Jul 19, 2023
View reviewed changes
lib/app/upload.ex Outdated Show resolved Hide resolved
nelsonic
nelsonic reviewed Jul 19, 2023
View reviewed changes
.github/workflows/fly.yml Outdated Show resolved Hide resolved
nelsonic
nelsonic reviewed Jul 19, 2023
View reviewed changes
api.md Show resolved Hide resolved
@nelsonic nelsonic added the question A question needs to be answered before progress can be made on this issue label Jul 19, 2023
@nelsonic nelsonic assigned LuchoTurtle and unassigned nelsonic Jul 19, 2023
nelsonic
nelsonic approved these changes Jul 19, 2023
View reviewed changes
Copy link
Member

@nelsonic nelsonic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @LuchoTurtle 👌

@nelsonic nelsonic merged commit 56fbca2 into main Jul 19, 2023
@nelsonic nelsonic deleted the err_fix branch July 19, 2023 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nelsonic nelsonic nelsonic approved these changes

Assignees

@LuchoTurtle LuchoTurtle

Labels
awaiting-review An issue or pull request that needs to be reviewed bug Suspected or confirmed bug (defect) in the code question A question needs to be answered before progress can be made on this issue
Projects
dwyl app kanban
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LuchoTurtle @nelsonic