vm: Change execution module to use execution::Config
#3430
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
herr-seppia
force-pushed
the
execution_config
branch
3 times, most recently
from
9431275 to
c3f48cc
Compare
moCello
previously approved these changes
Jan 28, 2025
- Move `block_gas_limit` into `RuskVmConfig` - Change DEFAULT_BLOCK_GAS_LIMIT to 3B
herr-seppia
force-pushed
the
execution_config
branch
from
c3f48cc to
39ddca2
Compare
moCello
approved these changes
Jan 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the
executionmodule to utilize thevm::execution::Configstructure, enhancing configuration management within the VM.Why?
Improved Code Modularity:
This change eliminates the need to pass individual variables across multiple functions, reducing clutter and ensuring that related parameters are logically grouped together.
Ease of Adding New Parameters:
By centralizing configuration into a single structure, the codebase is better prepared for future expansions, such as incorporating new ABIs or additional VM parameters. (See also rusk: add Moonlight TX sender metadata as host function #3341)
Additionally, this refactor introduces a new
RuskVMConfigstruct, which consolidates additional VM-related configurations not required by theexecutionmodule itself. Examples includegeneration_timeoutandblock_gas_limit, which are now properly scoped and managed within this structure.