Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rusk: group execution params together #3437

Closed
herr-seppia opened this issue Jan 28, 2025 · 1 comment · Fixed by #3430
Closed

rusk: group execution params together #3437

herr-seppia opened this issue Jan 28, 2025 · 1 comment · Fixed by #3430

Comments

@herr-seppia
Copy link
Member

Summary

Currently, multiple settings are passed here and there to proper handle the transaction execution.
This lead to unclarity and non maintainability of the code, explicitly adding [allow(clippy::too_many_arguments)] to pass the CI

Possible solution design or implementation

Group the fields together
herr-seppia added a commit that referenced this issue Jan 28, 2025
@herr-seppia
vm: Change execution module to use execution::Config
54c6193 
See also #3437
@moCello moCello linked a pull request Jan 29, 2025 that will close this issue
vm: Change execution module to use execution::Config #3430
Merged
@moCello
Copy link
Member

moCello commented Jan 29, 2025

Closed by #3430

@moCello moCello closed this as completed Jan 29, 2025
herr-seppia added a commit that referenced this issue Jan 31, 2025
@herr-seppia
rusk: change accept to take block header
94b32d9 
See also #3437
@herr-seppia herr-seppia mentioned this issue Jan 31, 2025
Open
herr-seppia added a commit that referenced this issue Feb 4, 2025
@herr-seppia
rusk: change accept to use block header
e18a45d 
See also #3437
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

vm: Change execution module to use execution::Config dusk-network/rusk
2 participants
@moCello @herr-seppia