rusk-wallet: Improve address handling #2594
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moCello
force-pushed
the
mocello/2580_fix_addresses
branch
2 times, most recently
from
2f003fd to
18b50df
Compare
moCello
requested review from
Daksh14,
miloszm,
HDauven,
xevisalle and
herr-seppia
xevisalle
previously approved these changes
Oct 7, 2024
moCello
force-pushed
the
mocello/2580_fix_addresses
branch
2 times, most recently
from
0c18fd1 to
7fd0074
Compare
herr-seppia
reviewed
Oct 7, 2024
The wallet addresses are now identified by their index internally.
moCello
force-pushed
the
mocello/2580_fix_addresses
branch
from
7fd0074 to
e370575
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the
indexfield from theAddressenum, so that it only either holds a phoenix public-key or bls public-key.Additionally the internal storage of addresses changes from
Vec<Address>toVec<(PhoenixPublicKey, BlsPublicKey)>.When the user selects and address from which to make a transaction from, she will select an index of the address keys. Depending on that index and the type of transaction that is performed, the wallet will choose the appropriate public-key from the
addresseslist.Resolves #2580