Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix tests since lasts commits break them silently #27

Merged
merged 6 commits into from
Oct 1, 2024

Conversation

WengerK
Copy link
Collaborator

@WengerK WengerK commented Oct 1, 2024

fix tests since update removing escape_implicit_backslashes & using string_implicit_backslashes

  • close 28

@WengerK WengerK force-pushed the fix-tests-since-workflow-disable branch from 613cb58 to 31cac26 Compare October 1, 2024 09:28
@WengerK
Copy link
Collaborator Author

WengerK commented Oct 1, 2024

I had to partially revert 15c9390 @FlorentTorregrosa - I created an issue to discuss about why the commit 15c9390 enforce addition of declare(strict_types=1). Because it's not a Drupal Best Practice nop ?

@WengerK WengerK force-pushed the fix-tests-since-workflow-disable branch from bf4f54e to 84e998b Compare October 1, 2024 09:37
@WengerK WengerK marked this pull request as ready for review October 1, 2024 10:44
@WengerK WengerK requested a review from drupol as a code owner October 1, 2024 10:44
@drupol
Copy link
Owner

drupol commented Oct 1, 2024

Please go ahead, there's no need to ask me for review, I don't use Drupal any longer...

@WengerK WengerK removed the request for review from drupol October 1, 2024 11:48
@WengerK
Copy link
Collaborator Author

WengerK commented Oct 1, 2024

Please go ahead, there's no need to ask me for review, I don't use Drupal any longer...

sorry Github added you automatically I will remove this automation (you're the owner of the repo that's why it add you to all PR - I'll try to take care not adding you in the future.

@WengerK WengerK merged commit 78fed0a into master Oct 1, 2024
10 checks passed
@WengerK WengerK deleted the fix-tests-since-workflow-disable branch October 1, 2024 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants