Commit 15c93909b51b5e4355bd60d8cdf37a428052f999 enforce declare(strict_types=1) - Was it intended ?

[WengerK]

Steps required to reproduce the problem

@FlorentTorregrosa in your commit 15c9390 you enable declare_strict_types therefore when using php-cs-fixer it will add declare(strict_types=1); at the top of each php files, wich is not a Drupal Best Practice.

Why having added this ? Was your intention to fix the declare(strict_types=1); format only ?

[FlorentTorregrosa]

Hi @WengerK ,

As mentioned in #20, since https://www.drupal.org/project/coder/releases/8.3.23, declare(strict_types=1); is in the Drupal coding standards.

[WengerK]

Only to format

https://www.drupal.org/node/3407995

Introduce SlevomatCodingStandard.TypeHints.DeclareStrictTypes to check for this standard, only applying this sniff when a strict type is set, so we don't enforce the usage of strict typing.

[WengerK]

Enforcing strict declarative is pretty invasive - do you agree to only check format on it ? Like Drupal do ?

[FlorentTorregrosa]

Oupsy, my bad.

As I already force it in my standards overrides I got warnings on all my projects, and as see it more and more in core and other contrib modules, I thought it was enforced.

So of course if Coder just enforce format if present, need to stick to that. And I will keep the enforce in my own overrides.

[WengerK]

I will revert a little of your commit then on #27 and merge it asap