fix: update.sh adds multiple lines to supports.sh #155 #156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
| # Reverse the file from filename or stdin | ||
| do_tac () { | ||
| if [ "$(uname)" == "Darwin" ]; then # Mac | ||
| # macOS doesn't have tac, so we use tail -r |
There was a problem hiding this comment.
Doesn't Linux have tail? So we could just use tail everywhere?
There was a problem hiding this comment.
Doesn't Linux have tail? So we could just use tail everywhere?
There is no -r option on linux (checked on ubuntu):
root@fe890b91bb61:/# tail -r test.txt
tail: invalid option -- 'r'
Try 'tail --help' for more information.
There was a problem hiding this comment.
Okay, that’s fine. Can you update the comment then to explain that macOS doesn’t have tac and Linux doesn’t have tail -r, hence the two approaches. Thanks for testing both.
Also please fix the whitespace on many of these lines; this repo uses tabs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue in update.sh was due $ is treated as address and means end of file in this line:
do_sed $"s|'${node_version}'|'${node_version}'\\n elif [[ \"\$1\" == ${new_meteor_version} ]]; then node_version='${new_node_version}'|" ./support.shAs sed works line by line there is no simple way to tell sed use the latest occurrence in the file (well at least I didn't find that). So my approach is a bit complicated but works well:
-ap