Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update.sh adds duplicated lines to support.sh #155

Closed
bladerunner2020 opened this issue Mar 17, 2024 · 1 comment
Closed

update.sh adds duplicated lines to support.sh #155

bladerunner2020 opened this issue Mar 17, 2024 · 1 comment

Comments

@bladerunner2020
Copy link
Contributor

When I run ./update.sh --meteor-version 2.15 --node-version 14.21.4 I got multiple lines with 2.15 in support.sh

image

This is because of this line:
do_sed $"s|'${node_version}'|'${node_version}'\\n elif [[ \"\$1\" == ${new_meteor_version} ]]; then node_version='${new_node_version}'|" ./support.sh

I think that $ before sed's substitute command is treated as address not as the latest occurrence.
bladerunner2020 added a commit to bladerunner2020/meteor-base that referenced this issue Mar 17, 2024
@bladerunner2020
fix: update.sh adds multiple lines to supports.sh disney#155
edeb2ea
GeoffreyBooth pushed a commit that referenced this issue Mar 18, 2024
@bladerunner2020
fix: update.sh adds multiple lines to supports.sh #155 (#156)
bf4189c 
* fix: update.sh adds multiple lines to supports.sh #155

* chore: added comment

* chore: converted indentation to tabs
@GeoffreyBooth
Copy link
Collaborator

Fixed by #156

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@GeoffreyBooth @bladerunner2020