Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VACMS 16962 Adds back to top to Billing and Insurance pages #2064

Merged
merged 2 commits into from
May 9, 2024

Conversation

eselkin
Copy link
Contributor

@eselkin eselkin commented May 6, 2024

Summary

  • Adds va-back-to-top to Billing and Insurance top-task page
  • Sitewide Facilities

Related issue(s)

Testing done

  • Manual check that DS component appears. Tested that component brings user back to top content on page in mobile and desktop.

Screenshots

Note: This field is mandatory for UI changes (non-component work should NOT have screenshots).

Desktop page
Mobile page

What areas of the site does it impact?

Billing and Insurance VAMC top-task pages

Acceptance criteria

  • VA back-to-top component appears

Quality Assurance & Testing

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Linting warnings have been addressed
  • Documentation has been updated (link to documentation *if necessary)
  • Screenshot of the developed feature is added
  • Accessibility testing has been performed

Error Handling

  • Browser console contains no warnings or errors.
  • Events are being sent to the appropriate logging solution
  • Feature/bug has a monitor built into Datadog or Grafana (if applicable)

Authentication

  • Did you login to a local build and verify all authenticated routes work as expected with a test user (does not affect authenticated content)

Requested Feedback

See that component appears either in images or on RI

@va-vfs-bot va-vfs-bot temporarily deployed to master/main/VACMS-16962-back-to-top-billing May 6, 2024 21:22 Inactive
@eselkin eselkin marked this pull request as ready for review May 6, 2024 21:46
@eselkin eselkin requested a review from a team as a code owner May 6, 2024 21:46
@eselkin
Copy link
Contributor Author

eselkin commented May 8, 2024

If you look at the desktop image, you'll see the spacing between the back to top and the Medallia button is larger (like it was in one of the PW fixes to this issue). Do we put the feedback button into the article like it is in the one that was cited here?

Most pages have the spacing like this one as opposed to the one in the comment above.
@thejordanwood @laflannery

@eselkin
Copy link
Contributor Author

eselkin commented May 8, 2024

I moved it, will update the image

@eselkin
Copy link
Contributor Author

eselkin commented May 8, 2024

Image is updated

@thejordanwood
Copy link

Thanks @eselkin! The spacing looks good to me.

@eselkin eselkin merged commit f04ae67 into main May 9, 2024
24 checks passed
@eselkin eselkin deleted the VACMS-16962-back-to-top-billing branch May 9, 2024 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants