Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VAMC Billing & Insurance: adopt V1 and V3 components where components are not used #16962

Closed
1 of 4 tasks
laflannery opened this issue Jan 22, 2024 · 7 comments
Closed
1 of 4 tasks
Assignees
Labels
accessibility Issues related to accessibility CY24-Q2 Calendar year Q2 2024 priority Facilities Facilities products (VAMC, Vet Center, etc) Public Websites Scrum team in the Sitewide crew sitewide VA.gov frontend CMS team practice area VAMC CMS managed product owned by Facilities team

Comments

@laflannery
Copy link
Contributor

laflannery commented Jan 22, 2024

Description

VAMC Billing & Insurance pages need the following updates to components:

Example pages:

Elements that are not using components that should be (Backlog)

  1. Telephone
    • The first phone number, for copay questions, is not using the component but should be using the v1
    • All other phone numbers are using the correct component
    • We should confirm that Exts in phone numbers within the component are parsed correctly
  2. Link
    • Facility names should use the link component
  3. Back to top component
    • Update 5/3: After determining that this component does not actually have built in intelligence to only show based on page height:
      • This should still be added, the Top task pages are on the longer side so having this on these pages will probably make sense more often than not.

Acceptance Criteria

  • Back to top component has been added
  • Update and run existing test(s).
  • If additional tests are needed, stub a ticket to note this for future work.
  • Requires accessibility review
@laflannery laflannery added Needs refining Issue status VAMC CMS managed product owned by Facilities team VA.gov frontend CMS team practice area Facilities Facilities products (VAMC, Vet Center, etc) accessibility Issues related to accessibility labels Jan 22, 2024
@maxx1128
Copy link

I estimate this ticket at a 3 for moving over a good amount of relatively simple elements over to components (deja vu)

@xiongjaneg xiongjaneg removed the Needs refining Issue status label Feb 28, 2024
@jilladams jilladams changed the title Update VAMC Billing & Insurance template with components Update VAMC Billing & Insurance template with components (v1) Mar 27, 2024
@laflannery
Copy link
Contributor Author

I removed the link component from this ticket, after working with PW, the link I noted on this page is CMS content and we are limited with what we can do with that type of content

@jilladams jilladams changed the title Update VAMC Billing & Insurance template with components (v1) VAMC Billing & Insurance: adopt V1 and V3 components where components are not used Mar 27, 2024
@laflannery
Copy link
Contributor Author

Telephone moved to #16148

@davidmpickett davidmpickett added the CY24-Q2 Calendar year Q2 2024 priority label Apr 11, 2024
@eselkin
Copy link
Contributor

eselkin commented Apr 24, 2024

2, Links will be handled by #16957 (similar to Records ticket)

@jilladams jilladams added the Public Websites Scrum team in the Sitewide crew label May 1, 2024
@eselkin eselkin self-assigned this May 3, 2024
@laflannery
Copy link
Contributor Author

laflannery commented May 10, 2024

@eselkin You mentioned in scrum you merged this, so I just checked and confirmed its on Prod, excellent. But for bookeeping purposes - I can't see a PR mentioned anywhere. Is that OK, not OK, should there be?

@eselkin
Copy link
Contributor

eselkin commented May 10, 2024

@laflannery Of course it's because I linked the zenhub ticket not the github ticket. Let me fix it department-of-veterans-affairs/content-build#2064

It's in prod: https://www.va.gov/northeast-ohio-health-care/billing-and-insurance/

@laflannery
Copy link
Contributor Author

Closing as Eli and I have both verified on Prod

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility Issues related to accessibility CY24-Q2 Calendar year Q2 2024 priority Facilities Facilities products (VAMC, Vet Center, etc) Public Websites Scrum team in the Sitewide crew sitewide VA.gov frontend CMS team practice area VAMC CMS managed product owned by Facilities team
Projects
None yet
Development

No branches or pull requests

6 participants