Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pin chrono version to fix arrow compilation failure #719

Merged
merged 4 commits into from
Feb 28, 2025
Merged

pin chrono version to fix arrow compilation failure #719

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
387c7aa
Update Cargo.toml
hntd187 Feb 27, 2025
ced4889
Update Cargo.toml
hntd187 Feb 27, 2025
64ef549
Revert change in Cargo.toml
hntd187 Feb 28, 2025
ce99fae
Update kernel/Cargo.toml
hntd187 Feb 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ keywords = ["deltalake", "delta", "datalake"]
license = "Apache-2.0"
repository = "https://github.com/delta-io/delta-kernel-rs"
readme = "README.md"
rust-version = "1.80"
rust-version = "1.81"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If arrow version didn't change, why do we need to bump the MSRV?
Did they bump their MSRV in a point release?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm seeing arrow is on 1.70? But I am seeing our MSRV failing with:

error: rustc 1.80.0 is not supported by the following packages:        │
  │   [email protected] requires rustc 1.81                                    │
  │   [email protected] requires rustc 1.81

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's weird... both those crates seem to be deep dependencies in icu_normalizer which in turn is a dep of url?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmmmm.. and Url has MSRV of 1.63.0..?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for now maybe let's just do the chrono fix and visit this separately?

version = "0.7.0"

[workspace.dependencies]
Expand Down
2 changes: 1 addition & 1 deletion kernel/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ pre-release-hook = [

[dependencies]
bytes = "1.7"
chrono = { version = "0.4" }
chrono = { version = "=0.4.39" }
fix-hidden-lifetime-bug = "0.2"
indexmap = "2.5.0"
itertools = "0.13"
Expand Down
Loading