pin chrono version to fix arrow compilation failure #719
Conversation
Current chrono 0.4.40 breaks building arrow, pin chrono to a prior version that does not break arrow.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #719 +/- ##
=======================================
Coverage 84.04% 84.05%
=======================================
Files 77 77
Lines 18063 18063
Branches 18063 18063
=======================================
+ Hits 15181 15182 +1
+ Misses 2164 2163 -1
Partials 718 718 ☔ View full report in Codecov by Sentry. |
github-actions
bot
added
the
breaking-change
Cargo.toml
Outdated
| @@ -19,7 +19,7 @@ keywords = ["deltalake", "delta", "datalake"] | |||
| license = "Apache-2.0" | |||
| repository = "https://github.com/delta-io/delta-kernel-rs" | |||
| readme = "README.md" | |||
| rust-version = "1.80" | |||
| rust-version = "1.81" | |||
There was a problem hiding this comment.
If arrow version didn't change, why do we need to bump the MSRV?
Did they bump their MSRV in a point release?
There was a problem hiding this comment.
I'm seeing arrow is on 1.70? But I am seeing our MSRV failing with:
error: rustc 1.80.0 is not supported by the following packages: │
│ [email protected] requires rustc 1.81 │
│ [email protected] requires rustc 1.81
There was a problem hiding this comment.
That's weird... both those crates seem to be deep dependencies in icu_normalizer which in turn is a dep of url?
There was a problem hiding this comment.
hmmmm.. and Url has MSRV of 1.63.0..?
|
I believe this has been since fixed upstream, I was able to remove the pin again and get it to build |
|
yep looks like arrow did a hotfix for but I think arrow 53 is still broken? |
Cargo.toml
Outdated
| @@ -19,7 +19,7 @@ keywords = ["deltalake", "delta", "datalake"] | |||
| license = "Apache-2.0" | |||
| repository = "https://github.com/delta-io/delta-kernel-rs" | |||
| readme = "README.md" | |||
| rust-version = "1.80" | |||
| rust-version = "1.81" | |||
There was a problem hiding this comment.
for now maybe let's just do the chrono fix and visit this separately?
Co-authored-by: Zach Schuermann <[email protected]>
zachschuermann
changed the title
github-actions
bot
added
the
breaking-change
What changes are proposed in this pull request?
Current chrono 0.4.40 breaks building arrow, pin chrono to a prior version that does not break arrow.
How was this change tested?
CI/CD