Feat: Billboard #192
Merged
Feat: Billboard #192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # Explorer/Assets/DCL/PluginSystem/DCL.Plugins.asmdef # Explorer/Assets/DCL/Tests/PlayMode/DCL.PlayMode.Tests.asmdef
|
Windows build successfull! You can find a link to the downloadable artifact below.
|
m3taphysics
reviewed
Dec 12, 2023
mikhail-dcl
requested changes
Dec 12, 2023
mikhail-dcl
approved these changes
Dec 12, 2023
|
Looks very cool, man 💪 I have just 3 suggestions:
|
popuz
reviewed
Dec 12, 2023
Explorer/Assets/Scripts/ECS/Unity/Transforms/Components/TransformComponent.cs
Show resolved
Hide resolved
Kinerius
pushed a commit
that referenced
this pull request
Feb 20, 2024
Introduced Billboard feature as Explorer/Assets/DCL/Billboard Locate at Nullables enabled Covered with tests For demo created scenes Assets/DCL/Billboard/Demo/BillboardDemoTest.unity - shows multiple Assets/DCL/Billboard/Demo/BillboardPlayground.unity - makes possible to tweak options in runtime and to see a difference IDemoWorld for easy reuse * dirty marker extensions for fluently * nullable enable feature activated * BillboardComponent * single instance entity extension * single entity optional extensions * Billboard feature, first version * billboards back to StaticContainer * gizmos forward debug tool * billboard component name correction * Billboard demo test * BillboardDemoTestBoot exclude settings * move Billboard as separated feature * remove redundant BillboardComponent, workflow on PbBillboard * array extensions * billboard world * worlds reorganize * tests base * billboard playground * math on bitwise BillboardSystem * nullable in test assembly: DLC/Tests/PlayMode * tests * fix asmdef with comma * async according convention * update cached values on apply * billboard remove colliders * demo world setup optimization * TransformComponent apply inlining * fix Apply rotation at TransformComponent, added world rotation update * TransformComponent optimize SetLocalPositionAndRotation * Billboard performance test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduced Billboard feature as Explorer/Assets/DCL/Billboard
Locate at
Nullables enabled
Covered with tests
For demo created scenes
Assets/DCL/Billboard/Demo/BillboardDemoTest.unity - shows multiple
Assets/DCL/Billboard/Demo/BillboardPlayground.unity - makes possible to tweak options in runtime and to see a difference
IDemoWorld for easy reuse