Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: AppArgs test and debug flag #1892

Merged
merged 1 commit into from
Aug 27, 2024
Merged

fix: AppArgs test and debug flag #1892

merged 1 commit into from
Aug 27, 2024

Conversation

NickKhalow
Copy link
Contributor

What does this PR change?

Args keys are presented without '--' prefix
...

How to test the changes?

  1. Launch the explorer
  2. Try with and without --debug flag

Our Code Review Standards

https://github.com/decentraland/unity-renderer/blob/master/docs/code-review-standards.md

@NickKhalow NickKhalow self-assigned this Aug 27, 2024
Copy link
Contributor

github-actions bot commented Aug 27, 2024

badge

Windows and Mac build successfull in Unity Cloud! You can find a link to the downloadable artifact below.

Name Link
Commit 4aaba06
Logs https://github.com/decentraland/unity-explorer/actions/runs/10574748199
Download Windows https://github.com/decentraland/unity-explorer/suites/27641425180/artifacts/1858780408
Download Mac https://github.com/decentraland/unity-explorer/suites/27641425180/artifacts/1858946871
Built on 2024-08-27T10:19:11Z

@GBirch33 GBirch33 self-requested a review August 27, 2024 10:29
@NickKhalow NickKhalow merged commit 98efe06 into main Aug 27, 2024
6 checks passed
@NickKhalow NickKhalow deleted the fix/debug-arg branch August 27, 2024 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants