AppArgs test and fix debug flag (#1892)

Explorer/Assets/Scripts/Global/AppArgs/ApplicationParametersParser.cs

@@ -1,4 +1,5 @@
 using System;
+using System.Collections;
 using System.Collections.Generic;
 using System.Collections.Specialized;
 using System.Text.RegularExpressions;
@@ -19,11 +20,13 @@ public class ApplicationParametersParser : IAppArgs
 
         public ApplicationParametersParser() : this(Environment.GetCommandLineArgs()) { }
 
-        public ApplicationParametersParser(string[] args)
+        public ApplicationParametersParser(string[] args) : this(true, args) { }
+
+        public ApplicationParametersParser(bool useInEditorFlags = true, params string[] args)
         {
             ParseApplicationParameters(args);
 
-            if (Application.isEditor)
+            if (useInEditorFlags && Application.isEditor)
                 AddAlwaysInEditorFlags();
         }
 
@@ -33,6 +36,9 @@ public bool HasFlag(string flagName) =>
         public bool TryGetValue(string flagName, out string? value) =>
             appParameters.TryGetValue(flagName, out value);
 
+        public IEnumerable<string> Flags() =>
+            appParameters.Keys;
+
         private void AddAlwaysInEditorFlags()
         {
             foreach ((string? key, string? value) in ALWAYS_IN_EDITOR)

Explorer/Assets/Scripts/Global/AppArgs/IAppArgs.cs

@@ -1,12 +1,16 @@
+using System.Collections.Generic;
+
 namespace Global.AppArgs
 {
     public interface IAppArgs
     {
-        public const string DEBUG_FLAG = "-debug";
+        public const string DEBUG_FLAG = "debug";
 
         bool HasFlag(string flagName);
 
         bool TryGetValue(string flagName, out string? value);
+
+        IEnumerable<string> Flags();
     }
 
     public static class AppArgsExtensions

Explorer/Assets/Scripts/Global/AppArgs/Tests/AppArgs.Tests.asmref

@@ -0,0 +1,3 @@
+{
+    "reference": "GUID:da80994a355e49d5b84f91c0a84a721f"
+}

Explorer/Assets/Scripts/Global/AppArgs/Tests/AppArgsTests.cs

@@ -0,0 +1,21 @@
+using NUnit.Framework;
+
+namespace Global.AppArgs.Tests
+{
+    public class AppArgsTest
+    {
+        [Test]
+        public void DebugArgFailTest()
+        {
+            IAppArgs args = new ApplicationParametersParser(false, "-debug");
+            Assert.False(args.HasDebugFlag(), $"flags in args: {string.Join(", ", args.Flags())}");
+        }
+
+        [Test]
+        public void DebugArgContainsTest()
+        {
+            IAppArgs args = new ApplicationParametersParser(false, "--debug");
+            Assert.True(args.HasDebugFlag(), $"flags in args: {string.Join(", ", args.Flags())}");
+        }
+    }
+}