Feature: Use Postgres env vars in absence of explicit config #190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexanderMann
requested changes
Aug 5, 2020
There was a problem hiding this comment.
@awm33 will have a better sense of whether this falls in line with the Singer standard for things. Fwiw, in my setup, I have a small wrapper which throws together this config from env vars, but they're not the PG defaults at all, but rather something more like DB__HOST, DB__PORT, ...
This allows the tap to be added into existing Postgres environments more easily, and reduces configuration duplication. The pre-existing config still takes precedence, and the defaults in the absence of config and env vars are what they were before. Signed-off-by: crwr45 <[email protected]>
|
@awm33 any movement here, anything that should be done? |
|
I think this would also help with security and following the 12 factor principles, as it removes the need for writing a password to a file |
|
@crwr45 could you have a quick look and make sure the tests are passing? Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows the tap to be added into existing Postgres environments
more easily, and reduces configuration duplication.
The pre-existing config still takes precedence, and the defaults
in the absence of config and env vars are what they were before.
Signed-off-by: crwr45 [email protected]