Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix case of f(dict_array, dict_array) invocation #64

Merged
merged 3 commits into from
Jan 15, 2025

Conversation

davidhewitt
Copy link
Collaborator

Follow up to #63

Fixes a related case where invoking with two dictionary arrays would unpack the first array and then zip with the second incorrectly (before repacking as a dictionary), leading to a corrupted output.

Now instead we iterate the two arrays without unpacking the first, and then wrap as a new dictionary to keep the data type.

@codecov-commenter
Copy link

codecov-commenter commented Jan 14, 2025

Codecov Report

Attention: Patch coverage is 68.57143% with 11 lines in your changes missing coverage. Please review.

Project coverage is 83.82%. Comparing base (38caf97) to head (add4038).

Files with missing lines Patch % Lines
src/common.rs 64.51% 11 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #64      +/-   ##
==========================================
- Coverage   84.22%   83.82%   -0.40%     
==========================================
  Files          15       15              
  Lines        1014     1045      +31     
  Branches     1014     1045      +31     
==========================================
+ Hits          854      876      +22     
- Misses        111      120       +9     
  Partials       49       49              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@davidhewitt davidhewitt merged commit cb0e669 into main Jan 15, 2025
7 checks passed
@davidhewitt davidhewitt deleted the dh/dict-column-invoke branch January 15, 2025 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants