Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Add conditional to not lock empty list of resources #1760

Merged
merged 1 commit into from
Feb 6, 2025
Merged

Fix: Add conditional to not lock empty list of resources #1760

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 10 additions & 5 deletions ...ataall/modules/s3_datasets_shares/services/share_processors/glue_table_share_processor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import logging
from contextlib import nullcontext
from typing import List
from warnings import warn
from datetime import datetime
Expand Down Expand Up @@ -244,11 +245,15 @@ def process_revoked_shares(self) -> bool:
log.info(f'Additional Resources to be locked while revoking glue tables: {additional_resources_to_lock}')

try:
with ResourceLockRepository.acquire_lock_with_retry(
resources=additional_resources_to_lock,
session=self.session,
acquired_by_uri=self.share_data.share.shareUri,
acquired_by_type=self.share_data.share.__tablename__,
with (
ResourceLockRepository.acquire_lock_with_retry(
resources=additional_resources_to_lock,
session=self.session,
acquired_by_uri=self.share_data.share.shareUri,
acquired_by_type=self.share_data.share.__tablename__,
)
if additional_resources_to_lock
else nullcontext()
):
log.info('##### Starting Revoking tables #######')
success = True
Expand Down
Loading