Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Add conditional to not lock empty list of resources #1760

Merged
merged 1 commit into from
Feb 6, 2025

Conversation

dlpzx
Copy link
Contributor

@dlpzx dlpzx commented Feb 6, 2025

Feature or Bugfix

  • Bugfix

Detail

In #1706 all the scenarios tested had multiple Datasets sharing a shared-Glue database. The issue is that when there is no common shared Glue database the lock will try to lock an empty list of resources, resulting in timeouts in backend/dataall/modules/s3_datasets_shares/services/share_processors/glue_table_share_processor.py:248

Relates

Security

Please answer the questions below briefly where applicable, or write N/A. Based on
OWASP 10.

  • Does this PR introduce or modify any input fields or queries - this includes
    fetching data from storage outside the application (e.g. a database, an S3 bucket)?
    • Is the input sanitized?
    • What precautions are you taking before deserializing the data you consume?
    • Is injection prevented by parametrizing queries?
    • Have you ensured no eval or similar functions are used?
  • Does this PR introduce any functionality or component that requires authorization?
    • How have you ensured it respects the existing AuthN/AuthZ mechanisms?
    • Are you logging failed auth attempts?
  • Are you using or adding any cryptographic features?
    • Do you use a standard proven implementations?
    • Are the used keys controlled by the customer? Where are they stored?
  • Are you introducing any new policies/roles/users?
    • Have you used the least-privilege principle? How?

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@dlpzx dlpzx marked this pull request as ready for review February 6, 2025 09:11
@dlpzx dlpzx merged commit 78e6143 into main Feb 6, 2025
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants