Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use replaceQueryParam when changing channels #2707

Merged
merged 1 commit into from
Nov 9, 2023
Merged

Conversation

devoncarew
Copy link
Member

@devoncarew devoncarew commented Nov 9, 2023

  • use GoRouter.replaceQueryParam when changing channels (replaces preserve query params when navigating #2704)
  • move the overflow menu to the last item on the toolbar
  • show 'external link' icons for the privacy notice and feedback links
  • default dartpad to the dark theme (instead of the system one)

  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.
Contribution guidelines:

Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.

Copy link
Member

@parlough parlough left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! All these changes work well :)

@johnpryan johnpryan merged commit 86689c0 into main Nov 9, 2023
4 checks passed
@johnpryan johnpryan deleted the router_updates branch November 9, 2023 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants