preserve query params when navigating

[devoncarew]

• preserve query params when navigating

When doing something like toggling the theme or channel, preserve any sample or id query param.

---

• I’ve reviewed the contributor guide and applied the relevant portions to this PR.

Contribution guidelines:

• See our contributor guide for general expectations for PRs.
• Larger or significant changes should be discussed in an issue before creating a PR.
• Contributions to our repos should follow the Dart style guide and use dart format.
• Most changes should add an entry to the changelog and may need to rev the pubspec package version.
• Changes to packages require corresponding tests.

Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.

[parlough]

Would you instead be able to use GoRouterState.of(this) and use the URI exposed from that state?

I haven't used go_router really, so not sure :)

[devoncarew]

It would be great to not have to reach directly to the window's url here. Happy to make changes here (and, John knows go_router well).

[johnpryan]

Here's the version I came up with. It gets the current URI from the GoRouter's routeInformationProvider instead.

[johnpryan]

Oops, I already implemented this in #2659. Would you mind taking a look at that version instead @devoncarew?

[devoncarew]

Oops, I already implemented this in #2659. Would you mind taking a look at that version instead @devoncarew?

No worries; lets land your PR and I can double check that its a superset of this one in terms of functionality.

[devoncarew]

closing in favor of #2707