[components][fix] Fix issue with additional scope determination #27043
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 11, 2025
OwenKephart
force-pushed
the
01-08-_components_docs_schema_viewer
branch
from
7488996 to
1fe20a5
Compare
OwenKephart
force-pushed
the
01-10-_components_fix_fix_issue_with_additional_scope_determination
branch
from
34d6a92 to
b85c7e5
Compare
OwenKephart
force-pushed
the
01-08-_components_docs_schema_viewer
branch
from
1fe20a5 to
200b269
Compare
OwenKephart
force-pushed
the
01-10-_components_fix_fix_issue_with_additional_scope_determination
branch
from
b85c7e5 to
b741d37
Compare
OwenKephart
force-pushed
the
01-08-_components_docs_schema_viewer
branch
2 times, most recently
from
983c653 to
3bd5528
Compare
OwenKephart
force-pushed
the
01-10-_components_fix_fix_issue_with_additional_scope_determination
branch
from
b741d37 to
ecdf2a8
Compare
benpankow
approved these changes
Jan 14, 2025
OwenKephart
force-pushed
the
01-08-_components_docs_schema_viewer
branch
from
3bd5528 to
392db15
Compare
OwenKephart
force-pushed
the
01-10-_components_fix_fix_issue_with_additional_scope_determination
branch
from
ecdf2a8 to
78418ae
Compare
OwenKephart
force-pushed
the
01-08-_components_docs_schema_viewer
branch
from
392db15 to
b1feabe
Compare
OwenKephart
force-pushed
the
01-10-_components_fix_fix_issue_with_additional_scope_determination
branch
from
78418ae to
217a183
Compare
OwenKephart
force-pushed
the
01-08-_components_docs_schema_viewer
branch
from
b1feabe to
91025ae
Compare
OwenKephart
force-pushed
the
01-10-_components_fix_fix_issue_with_additional_scope_determination
branch
from
217a183 to
a92b720
Compare
OwenKephart
force-pushed
the
01-08-_components_docs_schema_viewer
branch
from
91025ae to
21fe4a1
Compare
OwenKephart
force-pushed
the
01-10-_components_fix_fix_issue_with_additional_scope_determination
branch
from
a92b720 to
023cb87
Compare
OwenKephart
force-pushed
the
01-08-_components_docs_schema_viewer
branch
from
21fe4a1 to
1f53636
Compare
OwenKephart
force-pushed
the
01-10-_components_fix_fix_issue_with_additional_scope_determination
branch
from
023cb87 to
f5bae12
Compare
OwenKephart
changed the base branch from
01-08-_components_docs_schema_viewer
to
graphite-base/27043
OwenKephart
force-pushed
the
01-10-_components_fix_fix_issue_with_additional_scope_determination
branch
from
f5bae12 to
24ec7c9
Compare
OwenKephart
deleted the
01-10-_components_fix_fix_issue_with_additional_scope_determination
branch
marijncv
pushed a commit
to marijncv/dagster
that referenced
this pull request
Jan 21, 2025
…ter-io#27043) ## Summary & Motivation Fixes a weird issue I ran into. In essence, in pydantic 3.8.x, the generated json schema will have the `json_schema_extras` stored on dereferenced json schemas of any subtype, whereas in 3.10.x, the extras will be stored on the reference itself. No idea why this is different but it is what it is. ## How I Tested These Changes ## Changelog NOCHANGELOG
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
Fixes a weird issue I ran into. In essence, in pydantic 3.8.x, the generated json schema will have the
json_schema_extrasstored on dereferenced json schemas of any subtype, whereas in 3.10.x, the extras will be stored on the reference itself. No idea why this is different but it is what it is.How I Tested These Changes
Changelog
NOCHANGELOG