Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[components] Convert params schema from classvar to classmethod #26925

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

OwenKephart
Copy link
Contributor

Summary & Motivation

I want to play around with more generic components, and I think having this be a classmethod is both more consistent with other methods a user might implement (e.g. load), and also more flexible

How I Tested These Changes

Changelog

Insert changelog entry or delete this section.

@OwenKephart OwenKephart force-pushed the 01-07-_components_convert_params_schema_from_classvar_to_classmethod branch from a615bdd to 9dbf553 Compare January 8, 2025 22:27
Copy link
Member

@schrockn schrockn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree. While we're here I would like the bike shed the name. "params" I think is confusing.

  • Component Schema (i like that this aligns with component.yaml convention)
  • DSL Schema

other thoughts?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants