Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hoists the run queue config from the run coordinator up to the instance #26932

Merged
merged 3 commits into from
Jan 21, 2025
Merged

hoists the run queue config from the run coordinator up to the instance #26932

merged 3 commits into from
Jan 21, 2025

Conversation

prha
Copy link
Member

@prha prha commented Jan 8, 2025 •
edited
Loading

Summary & Motivation

For ease of use, #26931 consolidates concurrency settings (including queued run coordinator settings) into a single deployment settings block.

This PR makes it so that run queue settings are now accessed off of the instance, instead of off of the run coordinator.

The run coordinator is a standalone-configured module. This makes it difficult to incorporate instance settings from other places.

How I Tested These Changes

BK

This was referenced Jan 8, 2025
Open
Merged
@prha Graphite App
Copy link
Member Author

prha commented Jan 8, 2025 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

@prha prha force-pushed the prha/hoist_run_queue_config branch from 13f2c3c to 4710c64 Compare January 9, 2025 00:26
@prha prha changed the base branch from prha/default_queued_run_coordinator to prha/ui_instance_page January 9, 2025 00:26
This was referenced Jan 9, 2025
Merged
Merged
Merged
Merged
Merged
Open
Open
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 9, 2025 •
edited
Loading

Deploy preview for dagit-core-storybook ready!

✅ Preview
https://dagit-core-storybook-h2nubou1y-elementl.vercel.app
https://prha-hoist-run-queue-config.core-storybook.dagster-docs.io

Built with commit f1b7934.
This pull request is being automatically deployed with vercel-action

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 9, 2025

Deploy preview for dagster-docs ready!

Preview available at https://dagster-docs-lwdnfbq61-elementl.vercel.app
https://prha-hoist-run-queue-config.dagster.dagster-docs.io

Direct link to changed pages:

@prha prha force-pushed the prha/ui_instance_page branch from a068773 to 4d471e9 Compare January 9, 2025 03:43
@prha prha force-pushed the prha/hoist_run_queue_config branch from 4710c64 to 2ce911a Compare January 9, 2025 03:43
@prha prha force-pushed the prha/ui_instance_page branch from 4d471e9 to 859dd4c Compare January 9, 2025 03:58
@prha prha force-pushed the prha/hoist_run_queue_config branch from 2ce911a to e5e8022 Compare January 9, 2025 03:58
This was referenced Jan 9, 2025
Open
Open
@prha prha marked this pull request as ready for review January 9, 2025 18:22
@prha prha requested review from gibsondan and schrockn January 9, 2025 18:22
gibsondan
gibsondan approved these changes Jan 9, 2025
View reviewed changes
Copy link
Member

@gibsondan gibsondan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems very reasonable, the run queue no longer really makes sense as an optional/pluggable component anymore the way it did when this was first added.

@prha prha force-pushed the prha/ui_instance_page branch from 859dd4c to be163cf Compare January 10, 2025 01:17
@prha prha force-pushed the prha/hoist_run_queue_config branch from e5e8022 to 32eec84 Compare January 10, 2025 01:17
@prha prha force-pushed the prha/ui_instance_page branch from be163cf to e7dc76b Compare January 10, 2025 23:23
@prha prha force-pushed the prha/hoist_run_queue_config branch from 32eec84 to 3ba911e Compare January 10, 2025 23:23
@prha prha force-pushed the prha/ui_instance_page branch from e7dc76b to 5b84e11 Compare January 16, 2025 00:02
@prha prha force-pushed the prha/hoist_run_queue_config branch from 3ba911e to 2bed622 Compare January 16, 2025 00:02
@prha prha force-pushed the prha/ui_instance_page branch from 5b84e11 to b5ec0b8 Compare January 16, 2025 00:19
@prha prha force-pushed the prha/hoist_run_queue_config branch from 2bed622 to 253141f Compare January 16, 2025 00:19
@prha prha mentioned this pull request Jan 16, 2025
Open
@prha prha force-pushed the prha/ui_instance_page branch from b5ec0b8 to 6df13a3 Compare January 16, 2025 20:23
@prha prha force-pushed the prha/hoist_run_queue_config branch from 253141f to 24f23d7 Compare January 16, 2025 20:23
@prha prha force-pushed the prha/ui_instance_page branch from 6df13a3 to 47d228f Compare January 17, 2025 01:08
@prha prha force-pushed the prha/hoist_run_queue_config branch from 24f23d7 to 16acc11 Compare January 17, 2025 01:08
@prha prha force-pushed the prha/ui_instance_page branch from 47d228f to 0af051b Compare January 17, 2025 02:27
@prha prha force-pushed the prha/hoist_run_queue_config branch from 16acc11 to 7dae80e Compare January 17, 2025 02:27
@prha prha force-pushed the prha/ui_instance_page branch from 0af051b to d199ebd Compare January 17, 2025 02:55
@prha prha force-pushed the prha/hoist_run_queue_config branch 2 times, most recently from 8649c64 to f1b7934 Compare January 17, 2025 22:29
@prha prha requested a review from neverett as a code owner January 17, 2025 22:29
@prha prha changed the base branch from prha/ui_instance_page to prha/graphql_concurrency_group January 17, 2025 22:30
@prha prha mentioned this pull request Jan 20, 2025
Merged
@prha prha force-pushed the prha/graphql_concurrency_group branch from 5ea38ab to 529046e Compare January 21, 2025 19:57
@prha prha force-pushed the prha/hoist_run_queue_config branch from f1b7934 to be7ec05 Compare January 21, 2025 19:57
Base automatically changed from prha/graphql_concurrency_group to master January 21, 2025 20:51
@prha prha merged commit 4d47bfa into master Jan 21, 2025
1 check passed
@prha prha deleted the prha/hoist_run_queue_config branch January 21, 2025 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gibsondan gibsondan gibsondan approved these changes

@schrockn schrockn Awaiting requested review from schrockn

@neverett neverett Awaiting requested review from neverett

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@prha @gibsondan