thread pool info to remote representation of assets #26801
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 3, 2025
prha
force-pushed
the
prha/external_concurrency
branch
from
ec8a4d6 to
d90c32d
Compare
prha
force-pushed
the
prha/asset_op_concurrency_key
branch
from
67085a7 to
21ae854
Compare
prha
force-pushed
the
prha/external_concurrency
branch
2 times, most recently
from
a1526d1 to
5ff2171
Compare
prha
force-pushed
the
prha/asset_op_concurrency_key
branch
from
a32b759 to
be83c16
Compare
prha
force-pushed
the
prha/external_concurrency
branch
from
5ff2171 to
9b6bafd
Compare
prha
force-pushed
the
prha/asset_op_concurrency_key
branch
from
be83c16 to
3e3a642
Compare
prha
force-pushed
the
prha/external_concurrency
branch
2 times, most recently
from
ce0a6fa to
51ab2b3
Compare
prha
force-pushed
the
prha/asset_op_concurrency_key
branch
from
818b6ed to
f52347d
Compare
prha
force-pushed
the
prha/external_concurrency
branch
from
51ab2b3 to
3c45061
Compare
prha
force-pushed
the
prha/asset_op_concurrency_key
branch
from
f52347d to
ce97f66
Compare
prha
force-pushed
the
prha/external_concurrency
branch
from
3c45061 to
5905530
Compare
This was referenced Jan 9, 2025
prha
changed the title
prha
force-pushed
the
prha/asset_op_concurrency_key
branch
from
ce97f66 to
ba49ba7
Compare
prha
force-pushed
the
prha/external_concurrency
branch
from
5905530 to
f73ce28
Compare
This was referenced Jan 9, 2025
prha
force-pushed
the
prha/external_concurrency
branch
from
c406982 to
7e2a6f3
Compare
prha
force-pushed
the
prha/asset_op_concurrency_key
branch
from
58ac167 to
20be47d
Compare
prha
force-pushed
the
prha/external_concurrency
branch
from
7e2a6f3 to
4fdcb49
Compare
prha
force-pushed
the
prha/asset_op_concurrency_key
branch
from
20be47d to
6b05bdc
Compare
prha
force-pushed
the
prha/external_concurrency
branch
from
4fdcb49 to
27f08bd
Compare
prha
force-pushed
the
prha/asset_op_concurrency_key
branch
from
6b05bdc to
197d7c1
Compare
prha
force-pushed
the
prha/external_concurrency
branch
from
27f08bd to
b640e9c
Compare
prha
force-pushed
the
prha/asset_op_concurrency_key
branch
from
197d7c1 to
b7bfa67
Compare
prha
force-pushed
the
prha/external_concurrency
branch
from
b640e9c to
3e695a9
Compare
prha
force-pushed
the
prha/asset_op_concurrency_key
branch
from
b7bfa67 to
9d20984
Compare
prha
force-pushed
the
prha/external_concurrency
branch
from
3e695a9 to
d72bd90
Compare
marijncv
pushed a commit
to marijncv/dagster
that referenced
this pull request
Jan 21, 2025
## Summary & Motivation Makes pool information available on the remote representation of assets. ## How I Tested These Changes BK
alangenfeld
reviewed
Jan 21, 2025
| @@ -159,6 +159,7 @@ class GraphDefSnap: | |||
| dep_structure_snapshot: DependencyStructureSnapshot | |||
| input_mapping_snaps: Sequence[InputMappingSnap] | |||
| output_mapping_snaps: Sequence[OutputMappingSnap] | |||
| pools: Set[str] | |||
There was a problem hiding this comment.
i think this will cause unstable snapshot ids across versions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
Makes pool information available on the remote representation of assets.
How I Tested These Changes
BK