Update C extraction tools to current main #809
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
franziskuskiefer
added
the
waiting-on-review
keks
approved these changes
Feb 18, 2025
There was a problem hiding this comment.
I am not very confident in my Docker-fu, but I think this looks good.
Maybe the landing page of the libcrux-c container on ghcr could use some comment on what it is for, though; namely that it provides the tools needed for the C extraction (Karamel, Eurydice, Charon).
yeah, we should add something there. It's just taking the readme by default. But that's an unrelated to the update here. I put it on an issue. |
franziskuskiefer
removed
the
waiting-on-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.