Refresh C code + fix c.yaml following latest eurydice/krml changes #782
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR also showcases improved control-flow reconstruction (CC @Nadrieril and @sonmarcho). |
|
This will require updating the toolchain. We probably won't get to that his week. Until #417 is fixed, that's a manual process. |
|
This has been addressed through a series of other PRs with #809 being the last one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The latest changes in krml/eurydice generate more precise header inclusion, meaning the mlkem avx2 public header no longer includes the sha3 avx2 public header (this is not necessary: only the mlkem avx2 C file needs that header), meaning that the intrinsics need to be directly included from the mlkem avx2 public header.