Working around regressions in typeclass inference in F* #177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I also added a drive-by fix that adds new hints for the correctness proofs. These are needed when upgrading F* and Z3. Since no code is changed, and it is related to the new F*, I folded it into this PR. |
|
This depends on cryspen/hax#440 |
franziskuskiefer
approved these changes
Jan 19, 2024
franziskuskiefer
requested changes
Jan 19, 2024
W95Psp
added a commit
to cryspen/hax
that referenced
this pull request
Jan 22, 2024
`Output` is an associated type, and wasn't constrainted in terms of universes. Thus, F* would fail unifying types while using this instance because the associated type could be of any universe. This is causing the failure in cryspen/libcrux#177.
|
I think I understood why the TC resolution is failing, I think cryspen/hax#444 is solving the issue I've pushed a temporary commit that pins Hax to the branch of cryspen/hax#444, let's revert it when the PR is merged |
W95Psp
force-pushed
the
karthik/secret-independence-fix-new-fstar
branch
from
3ba0d7d to
17ebe17
Compare
W95Psp
approved these changes
Jan 22, 2024
franziskuskiefer
approved these changes
Jan 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a couple of places where F* 2024.01.13 fails but F* 2023.09.03 used to succeed.
The issue appears when a typeclass instance is used within an arithmetic or logical expression.