Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(proof-libs/fstar): make t_Index.Output universe zero #444

Merged
merged 3 commits into from
Jan 22, 2024

Conversation

W95Psp
Copy link
Collaborator

@W95Psp W95Psp commented Jan 22, 2024

Output is an associated type, and wasn't constrainted in terms of universes. Thus, F* would fail unifying types while using this instance because the associated type could be of any universe. This is causing the failure in cryspen/libcrux#177.

`Output` is an associated type, and wasn't constrainted in terms of
universes.  Thus, F* would fail unifying types while using this
instance because the associated type could be of any universe. This is
causing the failure in cryspen/libcrux#177.
Copy link
Contributor

@karthikbhargavan karthikbhargavan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah yes, I did not see this. I approve, but can you do a search through all the libraries to fix all universes to 0? E.g. I think. we used 'a in some places, and I removed those, but am not sure I got everything.

@W95Psp
Copy link
Collaborator Author

W95Psp commented Jan 22, 2024

I think things are fine, the library is type-checking just fine! Will look for 'a anyway just in case
Though, I've just pushed a commit that propagates this Type0 for every occurrence of "associated type"/type families in typeclasses.

EDIT: ah, now I have regressions

@W95Psp W95Psp enabled auto-merge January 22, 2024 12:05
@W95Psp W95Psp added this pull request to the merge queue Jan 22, 2024
Merged via the queue into main with commit 83d3fae Jan 22, 2024
9 checks passed
@W95Psp W95Psp deleted the monomorphize-assoc-type-universe-index branch January 22, 2024 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants