Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move solve to OptimalControl #233

Merged
merged 6 commits into from
Jul 15, 2024
Merged

move solve to OptimalControl #233

merged 6 commits into from
Jul 15, 2024

Conversation

PierreMartinon
Copy link
Member

@PierreMartinon PierreMartinon commented Jul 15, 2024

Cf control-toolbox/CTDirect.jl#175

  • solve was moved to OptimalControl
  • error message for missing extension (NLPModelsIpopt)
  • some default parameters update

@PierreMartinon
Copy link
Member Author

NB. tests cannot pass until the PR in CTDirect is merged and a new release done

@ocots
Copy link
Member

ocots commented Jul 15, 2024

NB. tests cannot pass until the PR in CTDirect is merged and a new release done

Note that now CTDirect.jl is in the general registry. So it different now to make a new release.

@PierreMartinon
Copy link
Member Author

PierreMartinon commented Jul 15, 2024

@ocots So, we can merge when tests are ok with the latest CTDirect 0.9.5 from General, and the release tomorrow should be fine ?

@ocots
Copy link
Member

ocots commented Jul 15, 2024

Dans la doc on a __time_grid_direct not defined.

@ocots
Copy link
Member

ocots commented Jul 15, 2024

I think we can merge. Ok?

@PierreMartinon
Copy link
Member Author

PierreMartinon commented Jul 15, 2024

const __time_grid_direct() = nothing is in CTDirect so I don't know what the problem was (and why only in the docs), but it works with nothing, so let's go ;-)

@ocots ocots merged commit 0eb9c07 into main Jul 15, 2024
2 checks passed
@ocots ocots deleted the move_solve branch July 15, 2024 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants