Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bring up complete motor controller yamcan definition #117

Merged
merged 3 commits into from
Feb 11, 2025
Merged

Bring up complete motor controller yamcan definition #117

merged 3 commits into from
Feb 11, 2025

Conversation

freeman803
Copy link
Contributor

Added YAMCAN defintions

freeman803
freeman803 commented Feb 1, 2025
View reviewed changes
network/NetworkGen/classes/Can.py
@@ -398,7 +398,6 @@ def validate_msg(self):
signal.start_bit + signal.native_representation.bit_width
)
except Exception as e:
breakpoint()
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed because shouldnt be there

@freeman803
Copy link
Contributor Author

freeman803 commented Feb 1, 2025 •
edited by JoshLafleur
Loading

Test Plan

  • Turn on Boss
  • Boss boots properly
  • message 0x202 is not present
  • send MC critical data
  • Message 0x202 is present
  • Message 0x202 byte 0-1 is max discharge
  • Message 0x202 byte 2-3 is max charge
    -Rest is MC Diff skip test for this for now

JoshLafleur
JoshLafleur requested changes Feb 1, 2025
View reviewed changes
Copy link
Collaborator

@JoshLafleur JoshLafleur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed that there will actually be some issues in the signal packing functionality of yamcan, id say make these corrections, do a little cleanup so everything is evely spaced and correct the few issues etc. I will look at correcting yamcan but may be best down the line

@JoshLafleur JoshLafleur linked an issue Feb 2, 2025 that may be closed by this pull request
Change MC current limit from being on Motec to the BMS #99
Closed
JoshLafleur
JoshLafleur requested changes Feb 4, 2025
View reviewed changes
Copy link
Collaborator

@JoshLafleur JoshLafleur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I highly recommend you go back over the canbus specification and what this document contains. Next review i will verify each signal is correctly indexed and placed and all message parameters. Double check all of your files, spacing, diffs. Make sure the things youre doing make sense. It sucks because its boiler plate but its gotta be done, especially that you will be using these signals

@freeman803 freeman803 force-pushed the AF_AF_MC_YAMCAN branch 6 times, most recently from 7adac13 to 71871f0 Compare February 6, 2025 19:45
@JoshLafleur JoshLafleur force-pushed the AF_AF_MC_YAMCAN branch 9 times, most recently from 9185a88 to 0300010 Compare February 11, 2025 17:58
This was linked to issues Feb 11, 2025
Add SNA values to all can enums #90
Closed
Output all build files to a single artifact #105
Closed
Prevent iilegal characters in signal and message names #121
Closed
@freeman803
Bring up complete motor controller yamcan definition
bd9b41a 
Added support for signal ID offset
Added support for duplicate detection in yamcan. Added detection of non alpah-numeric signal and message names
@JoshLafleur JoshLafleur merged commit c4b5324 into master Feb 11, 2025
3 checks passed
@JoshLafleur JoshLafleur deleted the AF_AF_MC_YAMCAN branch February 11, 2025 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoshLafleur JoshLafleur JoshLafleur approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@freeman803 @JoshLafleur