Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change MC current limit from being on Motec to the BMS #99

Closed
JoshLafleur opened this issue Nov 11, 2024 · 0 comments · Fixed by #117
Closed

Change MC current limit from being on Motec to the BMS #99

JoshLafleur opened this issue Nov 11, 2024 · 0 comments · Fixed by #117
Labels
BMSB Tracker for all BMSB Tickets good first issue Good for newcomers help wanted Extra attention is needed improvement Improvement on an existing feature YAMCAN Tracker for all YAMCAN issues

Comments

@JoshLafleur
Copy link
Collaborator

Currently the motec sends a BMS limit message to the motor controller. This can be done by the BMS at the same periodicity
@JoshLafleur JoshLafleur added BMSB Tracker for all BMSB Tickets YAMCAN Tracker for all YAMCAN issues improvement Improvement on an existing feature good first issue Good for newcomers help wanted Extra attention is needed labels Nov 11, 2024
@JoshLafleur JoshLafleur linked a pull request Feb 2, 2025 that will close this issue
Bring up complete motor controller yamcan definition #117
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
BMSB Tracker for all BMSB Tickets good first issue Good for newcomers help wanted Extra attention is needed improvement Improvement on an existing feature YAMCAN Tracker for all YAMCAN issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Bring up complete motor controller yamcan definition concordia-fsae/firmware
1 participant
@JoshLafleur