Add type annotations #95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 11, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #95 +/- ##
==========================================
- Coverage 87.54% 86.61% -0.94%
==========================================
Files 1 1
Lines 265 269 +4
Branches 41 41
==========================================
+ Hits 232 233 +1
- Misses 25 28 +3
Partials 8 8 ☔ View full report in Codecov by Sentry. |
asmacdo
reviewed
Jun 11, 2024
| ) -> Tuple[Union[TextIO, TailPipe, int], Union[TextIO, TailPipe, int]]: | ||
| stdout: Union[TextIO, TailPipe, int] | ||
| stderr: Union[TextIO, TailPipe, int] | ||
| ) -> tuple[TextIO | TailPipe | int | None, TextIO | TailPipe | int | None]: |
There was a problem hiding this comment.
why tuple instead of typing.Tuple?
There was a problem hiding this comment.
The typing types for builtins (Dict, Tuple, List, etc.) are all deprecated in favor of just using the types themselves.
|
Thank you!!!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #47.