Add dedicated SystemInfo type #96
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #96 +/- ##
==========================================
- Coverage 87.36% 86.90% -0.46%
==========================================
Files 1 1
Lines 269 275 +6
Branches 41 42 +1
==========================================
+ Hits 235 239 +4
- Misses 26 28 +2
Partials 8 8 ☔ View full report in Codecov by Sentry. |
asmacdo
reviewed
Jun 11, 2024
| @@ -183,7 +191,9 @@ def __repr__(self) -> str: | |||
| return json.dumps( | |||
| { | |||
| "command": self.command, | |||
| "system": self.system_info, | |||
| "system": ( | |||
| None if self.system_info is None else asdict(self.system_info) | |||
There was a problem hiding this comment.
dataclasses keep getting cooler :)
asmacdo
reviewed
Jun 11, 2024
Co-authored-by: Austin Macdonald <[email protected]>
|
@asmacdo Rebased. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR builds on top of #95.