Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Activate team section #834

Merged
merged 98 commits into from
Jun 10, 2022
Merged

Activate team section #834

merged 98 commits into from
Jun 10, 2022

Conversation

edwardchalstrey1
Copy link
Contributor

@edwardchalstrey1 edwardchalstrey1 commented Jun 6, 2022

Closes #730

Hi @polly64 I've updated the Team section as per your specs, however you'll definitely want to check how this looks on https://cl-staging.uksouth.cloudapp.azure.com/ before we roll it out.

In particular, I've made a few judgement calls:

  1. Kept the "Year built" field (which is the same as the Age category) separate from "Year extension built", which only shows up if you click a "Is there an extension?" Yes/No
  2. Added Verify buttons to everything to be consistent with the other categories

One thing that this doesn't cover is a situation where there is >1 extensions built in different years - is this something we want to include? Let's chat about this when you have time.

@tomalrussell @matkoniecz if you have any comments on the code let me know, thx - in particular the way I've handled the React components for the extension logic - see line 53 of team.tsx

@polly64
Copy link
Contributor

polly64 commented Jun 7, 2022

Hi @edwardchalstrey1 how do i view the dropdowns etc. I can't activate the edit on staging so they are all greyed out.
Yes need a plus button for each extension which basically enable all the attributes we're collecting to be added to each major extension. Multiple major extensions will be rare but option needed for big/old buildings such as British Museum etc so need to know date, designer etc.

would be great to release what's up today to try and catch up

@polly64
Copy link
Contributor

polly64 commented Jun 7, 2022

@edwardchalstrey1 thanks made new account.
could you add

  • 'religious body' to the"What type of developer built the building?" dropdown
  • 'architect/architectural firm' to the designer dropdown istead of just 'architectural firm'

also

  • the building needs to colour the more data categories are filled - i.e. exactly same format as for 'Location' data- can you use green or orange colour scale instead of the blue, could u add copying that code?
  • realise we need to be able to capture data on whole building and on all extensions at same time or separately . i.e. rather than having an either/or - meaning you have to state the whole process again for each extension - any thoughts re quick fix for this? <- created new issue Update Team section to support multiple extensions per building colouring-britain#255
  • the verify button wouldn't work til i had saved other stuff , could u check?< EC: I think this is the same as elsewhere
  • developer actually also needs source link
  • Add 'Name of builder/construction team
  • Add source link for the builder
  • Add Names of other significant members of the team - allow multiple additions
  • Allow source links and verifications for each
  • Add developer name
  • add source for developer and verification button

@edwardchalstrey1 edwardchalstrey1 merged commit 3140f57 into master Jun 10, 2022
@edwardchalstrey1 edwardchalstrey1 deleted the activate-team branch June 10, 2022 14:35
@polly64
Copy link
Contributor

polly64 commented Jun 11, 2022

Hi @edwardchalstrey1 looking great. I've just been testing and this is list to come out of it

GENERAL

LOCATION
#837

FOR TEAM
#838

FOR AGE
Moved to #726

FOR PLANNING
#838

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Facilitate building attribute data upload for Team
2 participants