Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Facilitate building attribute data upload for Team #730

Closed
11 of 12 tasks
edwardchalstrey1 opened this issue Jan 19, 2022 · 10 comments · Fixed by #834
Closed
11 of 12 tasks

Facilitate building attribute data upload for Team #730

edwardchalstrey1 opened this issue Jan 19, 2022 · 10 comments · Fixed by #834
Assignees

Comments

@edwardchalstrey1
Copy link
Contributor

edwardchalstrey1 commented Jan 19, 2022

@matkoniecz @edwardchalstrey1 CLHEAG committee priority to activate

  • Add main Note to contributor in a blue box (using same format as for 'Current use') saying:
    'Can you help us capture information on who built the current building?'

  • 1a. Add text 'Do you wish to add information on:
    'The main building?' OR 'A major extension?'

This answer leads you to the same questions for each option:

  • 2a. Add question 'When was the work carried out?'
    (If this relates to the main building and not an extension, and the age already been provided under 'Age ', it should automatically prepopulate - as code for age in Dynamics, but also make sure if someone adds age for Team that it prepopulates the other way too i.e. in Age)

  • 2b. Add verify- to also verify at same time for same entry in 'Age'

  • 2c. Add Source link but no verification for source (only allow urls to be entered)

  • 3a. Add question: 'What type of developer built the building?'
    (This is the dropdown for ownership as under 'Community' which i have just noticed hasn't been activated- i thought it had could you check?)
    a) State
    b) Charity
    c) Community/Cooperative
    d) Other non-profit body
    f) Private (jndividual)
    g) Private (company/estate)
    h) Other

  • 4.a Add 'Who was/were the main designer/s?' (Free text. First name, space, then Last name- include constraints to maximise security i.e. max number of characters) Use plus button as in land use to allow addition of up to five designers

  • 4b. Add verify

  • 4c. Add Source link but no verification for source

  • 4d. How best describes the lead designer?
    Landowner
    Speculative builder
    Government architecture department
    Architectural firm
    Engineering firm
    Other

  • 5.a Add 'Did the team win any awards for this building?'

  • 5b. If yes 'Add source link' and plus button so you can add up to 5

@polly64

This comment has been minimized.

@matkoniecz
Copy link
Contributor

matkoniecz commented Feb 16, 2022

@polly64

Has the team won any prizes/awards?

Is user supposed to answer yes if designer won prizes for other building? Maybe

Has the team won any prizes/awards for this building?

or similar would be better?


Has this building had a major extension?

@matkoniecz
Copy link
Contributor

@polly64

'Do you wish to add information on: the main building? OR a major extension?

Is it supposed to be yes/no field?

Or is it supposed to be possible to answer all this questions for both (1) initial construction (2) major extension (3) another major extension (4) yet another extension etc?

In case of the second version it would be much harder to implement properly.

@polly64
Copy link
Contributor

polly64 commented Mar 28, 2022

@matkoniecz - [ ] can we allow for people to add info more that one designer (ie use plus sign as in dynamics)
- [ ] can we add maximum characters for first names as 15 and surnames as 15

@tomalrussell
Copy link
Contributor

Just to chip in on names - see these notes on personal names which walks through some of the variety in personal names.

Suggest a single "name" or "full name" field for simplicity, with generous character limit (perhaps 90).

@polly64
Copy link
Contributor

polly64 commented Mar 29, 2022

@tomalrussell thanks @matkoniecz

@edwardchalstrey1 edwardchalstrey1 self-assigned this May 30, 2022
@polly64
Copy link
Contributor

polly64 commented May 30, 2022

@edwardchalstrey1 have updated teams list

@edwardchalstrey1
Copy link
Contributor Author

edwardchalstrey1 commented Jun 1, 2022

2c. Add Source link but no verification for source (only allow urls to be entered)
@polly64 few Qs:

  1. Should this part work the same way as for the Age category, with both a "Source of information" dropdown and a "Text and Image Links" text box?
    Hi @edwardchalstrey1 I can't see the link box any more on the main platform could you check for Age what' happened there?
    No dropdown here

  2. For the case where 'The main building' is selected, should we again inherit the values for both of those from the Age category? When 'A major extension' is selected, we can have them empty, the same as for the 'When was the work carried out?' dropdown.

When main building is selected then we want to inherit values from the main 'Age' box and vice versa
When major extension is selected then this is more complicated. The user needs to be able in both 'Age' and 'Teams' to add information on any number of major extensions (likely to not be more than 5 per building though for things like British Museum will be more). In the age section this just means adding a section at the bottom saying 'Date of any major extensions and allowing user to click plus button (as in land use) and keep adding.
In the 'team's category we will need to collect all the information for all the categories - this won't happen very often, and then have a concertina thing that allows you to open up all the major extension data relation to a single building

  1. Why do we not want Verify button(s) here? Since these have been added for the Source and Source link fields elsewhere
    Ah, ok so i think I'm not sure whether these are so necessary on the source and dropdowns. I would put on sources but not on dropdowns

(This is the dropdown for ownership as under 'Community' which i have just noticed hasn't been activated- i thought it had could you check?)

Looks to be activated to me on the live site
yup working now thanks let me kow if anything doesn't make sense

@edwardchalstrey1
Copy link
Contributor Author

@polly64 the link box only appears when you select certain options on "Source of information" i.e. not the top 2

@polly64
Copy link
Contributor

polly64 commented Jun 13, 2022

This comment was copied here

@polly64 polly64 closed this as completed Jun 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants