NatSpec improvements

.gas-snapshot

@@ -23,7 +23,7 @@ CoinbaseSmartWalletFactoryTest:test_implementation_returnsExpectedAddress() (gas
 CoinbaseSmartWalletFactoryTest:test_initCodeHash() (gas: 7912)
 CoinbaseSmartWalletFactoryTest:test_revertsIfNoOwners() (gas: 29232)
 ERC1271Test:test_returnsExpectedDomainHashWhenProxy() (gas: 29243)
-ERC1271Test:test_static() (gas: 3238027)
+ERC1271Test:test_static() (gas: 3240637)
 MultiOwnableInitializeTest:testRevertsIfLength32ButLargerThanAddress() (gas: 81111)
 MultiOwnableInitializeTest:testRevertsIfLength32NotAddress() (gas: 81092)
 MultiOwnableInitializeTest:testRevertsIfLengthNot32Or64() (gas: 103395)
@@ -43,31 +43,30 @@ RemoveOwnerAtIndexTest:test_revert_whenWrongOwnerAtIndex() (gas: 36728)
 RemoveOwnerAtIndexTest:test_reverts_ifIsLastOwner() (gas: 7647492)
 TestCanSkipChainIdValidation:test_approvedSelectorsReturnTrue() (gas: 17781)
 TestCanSkipChainIdValidation:test_otherSelectorsReturnFalse() (gas: 12579)
-TestExecuteWithoutChainIdValidation:testExecute() (gas: 424882)
+TestExecuteWithoutChainIdValidation:testExecute() (gas: 403873)
 TestExecuteWithoutChainIdValidation:testExecuteBatch() (gas: 728942)
-TestExecuteWithoutChainIdValidation:testExecuteBatch(uint256) (runs: 256, μ: 3590200, ~: 3466169)
-TestExecuteWithoutChainIdValidation:test__codesize() (gas: 49931)
-TestExecuteWithoutChainIdValidation:test__codesize() (gas: 50166)
-TestExecuteWithoutChainIdValidation:test_revertsWithReservedNonce() (gas: 81983)
+TestExecuteWithoutChainIdValidation:testExecuteBatch(uint256) (runs: 256, μ: 3608152, ~: 3468946)
+TestExecuteWithoutChainIdValidation:test__codesize() (gas: 50179)
+TestExecuteWithoutChainIdValidation:test_revertsWithReservedNonce() (gas: 81941)
 TestExecuteWithoutChainIdValidation:test_reverts_whenCallerNotEntryPoint() (gas: 11031)
 TestExecuteWithoutChainIdValidation:test_reverts_whenOneCallReverts() (gas: 467783)
 TestExecuteWithoutChainIdValidation:test_reverts_whenOneSelectorNotApproved() (gas: 179662)
 TestExecuteWithoutChainIdValidation:test_reverts_whenSelectorNotApproved() (gas: 106736)
-TestExecuteWithoutChainIdValidation:test_succeeds_whenSelectorAllowed() (gas: 423939)
+TestExecuteWithoutChainIdValidation:test_succeeds_whenSelectorAllowed() (gas: 423963)
 TestImplementation:testImplementation() (gas: 12558)
 TestInitialize:testInitialize() (gas: 21012)
-TestInitialize:test_cannotInitImplementation() (gas: 2887326)
+TestInitialize:test_cannotInitImplementation() (gas: 2889926)
 TestIsValidSignature:testReturnsInvalidIfPasskeySigButWrongOwnerLength() (gas: 40165)
 TestIsValidSignature:testRevertsIfEthereumSignatureButWrongOwnerLength() (gas: 24018)
 TestIsValidSignature:testRevertsIfOwnerIsInvalidEthereumAddress() (gas: 21999)
-TestIsValidSignature:testSmartWalletSigner() (gas: 3168925)
+TestIsValidSignature:testSmartWalletSigner() (gas: 3171533)
 TestIsValidSignature:testValidateSignatureWithEOASigner() (gas: 24900)
 TestIsValidSignature:testValidateSignatureWithEOASignerFailsWithWrongSigner() (gas: 23855)
 TestIsValidSignature:testValidateSignatureWithPasskeySigner() (gas: 423216)
 TestIsValidSignature:testValidateSignatureWithPasskeySignerFailsBadOwnerIndex() (gas: 35642)
 TestIsValidSignature:testValidateSignatureWithPasskeySignerFailsWithWrongBadSignature() (gas: 430682)
 TestUpgradeToAndCall:testUpgradeToAndCall() (gas: 25499)
-TestValidateUserOp:test_reverts_whenReplayableNonceKeyInvalidForSelector() (gas: 14187)
-TestValidateUserOp:test_reverts_whenSelectorInvalidForReplayableNonceKey() (gas: 14452)
-TestValidateUserOp:test_succeedsWithEOASigner() (gas: 447938)
-TestValidateUserOp:test_succeedsWithPasskeySigner() (gas: 785169)
+TestValidateUserOp:test_reverts_whenReplayableNonceKeyInvalidForSelector() (gas: 14211)
+TestValidateUserOp:test_reverts_whenSelectorInvalidForReplayableNonceKey() (gas: 14476)
+TestValidateUserOp:test_succeedsWithEOASigner() (gas: 448010)
+TestValidateUserOp:test_succeedsWithPasskeySigner() (gas: 785193)

.github/workflows/test.yml

@@ -38,6 +38,11 @@ jobs:
           forge fmt --check
         id: fmt
 
+      - name: Check snapshot
+        run: |
+          forge snapshot --check
+        id: snapshot
+
   forge-coverage:
       name: Run Coverage Reporting
       runs-on: ubuntu-latest

foundry.toml

@@ -3,4 +3,8 @@ src = "src"
 out = "out"
 libs = ["lib"]
 
+[fmt]
+sort_imports = true
+wrap_comments = true
+
 # See more config options https://github.com/foundry-rs/foundry/blob/master/crates/config/README.md#all-options

script/DeployERC4337Factory.s.sol

@@ -3,7 +3,7 @@ pragma solidity ^0.8.13;
 
 import {Script, console2} from "forge-std/Script.sol";
 
-import {CoinbaseSmartWalletFactory, CoinbaseSmartWallet} from "../src/CoinbaseSmartWalletFactory.sol";
+import {CoinbaseSmartWallet, CoinbaseSmartWalletFactory} from "../src/CoinbaseSmartWalletFactory.sol";
 
 contract ERC4337FactoryDeployScript is Script {
     function setUp() public {}