Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NatSpec improvements #64

Merged
merged 13 commits into from
Apr 22, 2024
Merged

NatSpec improvements #64

merged 13 commits into from
Apr 22, 2024

Conversation

wilsoncusack
Copy link
Contributor

No description provided.

xenoliss
xenoliss reviewed Apr 21, 2024
View reviewed changes
Copy link
Contributor

@xenoliss xenoliss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly indentation. Do we want to stick to a specific format regarding NatSpec indentation? What about max line length as well for comments?

src/CoinbaseSmartWallet.sol Outdated Show resolved Hide resolved
src/CoinbaseSmartWallet.sol Outdated Show resolved Hide resolved
src/CoinbaseSmartWallet.sol Outdated Show resolved Hide resolved
src/CoinbaseSmartWallet.sol Outdated Show resolved Hide resolved
src/CoinbaseSmartWallet.sol Outdated Show resolved Hide resolved
src/CoinbaseSmartWalletFactory.sol Outdated Show resolved Hide resolved
src/ERC1271.sol Outdated Show resolved Hide resolved
src/MultiOwnable.sol Outdated Show resolved Hide resolved
src/MultiOwnable.sol Outdated Show resolved Hide resolved
src/MultiOwnable.sol Outdated Show resolved Hide resolved
@wilsoncusack
Copy link
Contributor Author

Mostly indentation. Do we want to stick to a specific format regarding NatSpec indentation? What about max line length as well for comments?

I just use forge fmt until we explicitly state something else.

@cb-heimdall
Copy link
Collaborator

Review Error for xenoliss @ 2024-04-22 13:35:22 UTC
User failed mfa authentication, see go/mfa-help

@wilsoncusack wilsoncusack merged commit 1b47c00 into main Apr 22, 2024
6 of 9 checks passed
@wilsoncusack wilsoncusack deleted the wilson/natspec branch April 22, 2024 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xenoliss xenoliss xenoliss approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wilsoncusack @cb-heimdall @xenoliss