Fix: cnf_installation tag was not being discovered after name change #2204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martin-mat
approved these changes
Jan 11, 2025
collivier
approved these changes
Jan 14, 2025
- GH actions tag discovery command requires that there is a space between colon and the left bracket, this wasn't discovered and the skip started occuring in #2184. - Additionally there was an undiscovered error due to this test being skipped, which is now resolved (a message that is to be checked was changed). Signed-off-by: svteb <[email protected]>
svteb
force-pushed
the
tags_correction
branch
from
762fecd to
a87f3ab
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
GH actions tag discovery command (
grep -roP --no-filename 'tags: \K(\[|")(.*)(\]|")' spec/ | tr -d '[],' | tr -s '\n' ' ' | xargs -n1 | sort -u | xargs | sed s/:/_/g) requires that there is a space between colon and the left bracket. This has gone unnoticed in the #2184 pull request and it is the only pull request that went unchecked (other existing pull requests will likely need to be rebased), since it did not change any functionality but merely renamed some tasks, this should not be a problem.Types of changes: