Skip to content

Commit

Permalink
Fix: cnf_installation tag was not being discovered after name change
Browse files Browse the repository at this point in the history
- GH actions tag discovery command requires that there is a space between
colon and the left bracket.
- This has gone unnoticed in the #2184 pull request.

Signed-off-by: svteb <[email protected]>
  • Loading branch information
svteb committed Jan 9, 2025
1 parent bb16348 commit 818f3d1
Showing 1 changed file with 15 additions and 15 deletions.
30 changes: 15 additions & 15 deletions spec/setup_spec.cr
Original file line number Diff line number Diff line change
Expand Up @@ -11,29 +11,29 @@ describe "Installation" do
result = ShellCmd.environment_cleanup()
end

it "'setup' should install all cnf-testsuite dependencies before installing cnfs", tags:["cnf_installation"] do
it "'setup' should install all cnf-testsuite dependencies before installing cnfs", tags: ["cnf_installation"] do
result = ShellCmd.run_testsuite("setup")
result[:status].success?.should be_true
(/Dependency installation complete/ =~ result[:output]).should_not be_nil
end

it "'cnf_install' should pass with a minimal cnf-testsuite.yml", tags:["cnf_installation"] do
it "'cnf_install' should pass with a minimal cnf-testsuite.yml", tags: ["cnf_installation"] do
result = ShellCmd.cnf_install("cnf-path=./sample-cnfs/sample-minimal-cnf/")
(/CNF installation complete/ =~ result[:output]).should_not be_nil
ensure
result = ShellCmd.cnf_uninstall()
(/All CNF deployments were uninstalled/ =~ result[:output]).should_not be_nil
end

it "'cnf_install/cnf_uninstall' should install/uninstall with cnf-config arg as an alias for cnf-path", tags:["cnf_installation"] do
it "'cnf_install/cnf_uninstall' should install/uninstall with cnf-config arg as an alias for cnf-path", tags: ["cnf_installation"] do
result = ShellCmd.cnf_install("cnf-config=./sample-cnfs/sample-minimal-cnf/")
(/CNF installation complete/ =~ result[:output]).should_not be_nil
ensure
result = ShellCmd.cnf_uninstall()
(/All CNF deployments were uninstalled/ =~ result[:output]).should_not be_nil
end

it "'cnf_install/cnf_uninstall' should install/uninstall with cnf-path arg as an alias for cnf-config", tags:["cnf_installation"] do
it "'cnf_install/cnf_uninstall' should install/uninstall with cnf-path arg as an alias for cnf-config", tags: ["cnf_installation"] do
begin
result = ShellCmd.cnf_install("cnf-path=example-cnfs/coredns/cnf-testsuite.yml")
(/CNF installation complete/ =~ result[:output]).should_not be_nil
Expand All @@ -43,7 +43,7 @@ describe "Installation" do
end
end

it "'cnf_install/cnf_uninstall' should fail on incorrect config", tags:["cnf_installation"] do
it "'cnf_install/cnf_uninstall' should fail on incorrect config", tags: ["cnf_installation"] do
begin
result = ShellCmd.cnf_install("cnf-path=spec/fixtures/sample-bad-config.yml", expect_failure: true)
(/Error during parsing CNF config/ =~ result[:output]).should_not be_nil
Expand All @@ -52,7 +52,7 @@ describe "Installation" do
end
end

it "'cnf_install/cnf_uninstall' should install/uninstall a cnf with a cnf-testsuite.yml", tags:["cnf_installation"] do
it "'cnf_install/cnf_uninstall' should install/uninstall a cnf with a cnf-testsuite.yml", tags: ["cnf_installation"] do
begin
result = ShellCmd.cnf_install("cnf-config=example-cnfs/coredns/cnf-testsuite.yml")
(/CNF installation complete/ =~ result[:output]).should_not be_nil
Expand All @@ -62,7 +62,7 @@ describe "Installation" do
end
end

it "'cnf_install/cnf_uninstall' should work with cnf-testsuite.yml that has no directory associated with it", tags:["cnf_installation"] do
it "'cnf_install/cnf_uninstall' should work with cnf-testsuite.yml that has no directory associated with it", tags: ["cnf_installation"] do
begin
#TODO force cnfs/<name> to be deployment name and not the directory name
result = ShellCmd.cnf_install("cnf-config=spec/fixtures/cnf-testsuite.yml verbose")
Expand All @@ -73,7 +73,7 @@ describe "Installation" do
end
end

it "'cnf_install/cnf_uninstall' should install/uninstall with helm_directory that descends multiple directories", tags:["cnf_installation"] do
it "'cnf_install/cnf_uninstall' should install/uninstall with helm_directory that descends multiple directories", tags: ["cnf_installation"] do
begin
result = ShellCmd.cnf_install("cnf-path=sample-cnfs/multi_helm_directories/cnf-testsuite.yml")
(/CNF installation complete/ =~ result[:output]).should_not be_nil
Expand All @@ -83,7 +83,7 @@ describe "Installation" do
end
end

it "'cnf_install/cnf_uninstall' should properly install/uninstall old versions of cnf configs", tags:["cnf_installation"] do
it "'cnf_install/cnf_uninstall' should properly install/uninstall old versions of cnf configs", tags: ["cnf_installation"] do
begin
result = ShellCmd.cnf_install("cnf-path=spec/fixtures/cnf-testsuite-v1-example.yml")
(/CNF installation complete/ =~ result[:output]).should_not be_nil
Expand All @@ -93,7 +93,7 @@ describe "Installation" do
end
end

it "'cnf_install' should fail if another CNF is already installed", tags:["cnf_installation"] do
it "'cnf_install' should fail if another CNF is already installed", tags: ["cnf_installation"] do
begin
result = ShellCmd.cnf_install("cnf-path=sample-cnfs/sample_coredns/cnf-testsuite.yml")
(/CNF installation complete/ =~ result[:output]).should_not be_nil
Expand All @@ -105,7 +105,7 @@ describe "Installation" do
end
end

it "'cnf_install/cnf_uninstall' should install/uninstall a cnf with multiple deployments", tags:["cnf_installation"] do
it "'cnf_install/cnf_uninstall' should install/uninstall a cnf with multiple deployments", tags: ["cnf_installation"] do
begin
result = ShellCmd.cnf_install("cnf-path=sample-cnfs/sample_multiple_deployments/cnf-testsuite.yml")
(/All "coredns" deployment resources are up/ =~ result[:output]).should_not be_nil
Expand All @@ -121,7 +121,7 @@ describe "Installation" do
end
end

it "'cnf_install/cnf_uninstall' should install/uninstall deployment with mixed installation methods", tags:["cnf_installation"] do
it "'cnf_install/cnf_uninstall' should install/uninstall deployment with mixed installation methods", tags: ["cnf_installation"] do
begin
result = ShellCmd.cnf_install("cnf-path=sample-cnfs/sample-nginx-redis/cnf-testsuite.yml")
(/All "nginx" deployment resources are up/ =~ result[:output]).should_not be_nil
Expand All @@ -135,7 +135,7 @@ describe "Installation" do
end
end

it "'cnf_install/cnf_uninstall' should handle partial deployment failures gracefully", tags:["cnf_installation"] do
it "'cnf_install/cnf_uninstall' should handle partial deployment failures gracefully", tags: ["cnf_installation"] do
begin
result = ShellCmd.cnf_install("cnf-path=sample-cnfs/sample-partial-deployment-failure/cnf-testsuite.yml", expect_failure: true)
(/All "nginx" deployment resources are up/ =~ result[:output]).should_not be_nil
Expand All @@ -146,7 +146,7 @@ describe "Installation" do
end
end

it "'cnf_install' should detect and report conflicts between deployments", tags:["cnf_installation"] do
it "'cnf_install' should detect and report conflicts between deployments", tags: ["cnf_installation"] do
begin
result = ShellCmd.cnf_install("cnf-path=spec/fixtures/sample-conflicting-deployments.yml", expect_failure: true)
(/Deployment names should be unique/ =~ result[:output]).should_not be_nil
Expand All @@ -155,7 +155,7 @@ describe "Installation" do
end
end

it "'cnf_install' should correctly handle deployment priority", tags:["cnf_installation"] do
it "'cnf_install' should correctly handle deployment priority", tags: ["cnf_installation"] do
# (kosstennbl) ELK stack requires to be installed with specific order, otherwise it would give errors
begin
result = ShellCmd.cnf_install("cnf-path=sample-cnfs/sample-elk-stack/cnf-testsuite.yml timeout=600")
Expand Down

0 comments on commit 818f3d1

Please sign in to comment.