Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Silence gcc 13.3.0 spurious array bounds warnings for std::vector initialization #47259

Closed
wants to merge 1 commit into from

Conversation

gartung
Copy link
Member

@gartung gartung commented Feb 4, 2025

gcc 13.3 produces spurious array bounds warning/error for std::vector initialization with curly braces.
addresses
#47218
#47219
#47220
#47221
#47222

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 4, 2025

cms-bot internal usage

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 4, 2025

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 4, 2025

A new Pull Request was created by @gartung for master.

It involves the following packages:

  • CondFormats/JetMETObjects (db)
  • L1Trigger/TrackFindingTMTT (l1)
  • L1Trigger/TrackFindingTracklet (l1)
  • PhysicsTools/MVAComputer (ml)
  • RecoEgamma/EgammaIsolationAlgos (reconstruction)
  • RecoTauTag/RecoTau (reconstruction)

@aloeliger, @atpathak, @cmsbuild, @consuegs, @epalencia, @francescobrivio, @jfernan2, @mandrenguyen, @perrotta, @valsdav, @y19y19 can you please review it and eventually sign? Thanks.
@AlexDeMoor, @JanChyczynski, @Martin-Grunewald, @Ming-Yan, @PonIlya, @Prasant1993, @Sam-Harper, @Senphy, @a-kapoor, @afiqaize, @ahinzmann, @andrzejnovak, @azotz, @castaned, @erikbutz, @gkasieczka, @jainshilpi, @jdamgov, @jdolen, @lgray, @mariadalfonso, @mbluj, @missirol, @mmarionncern, @mmusich, @nhanvtran, @ram1123, @rappoccio, @rsreds, @sameasy, @schoef, @seemasharmafnal, @skinnari, @sobhatta, @valsdav, @varuns23, @yuanchao this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@gartung
Copy link
Member Author

gartung commented Feb 4, 2025

please test for el8_amd64_gcc13

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 5, 2025

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d80b39/44192/summary.html
COMMIT: 21fce4b
CMSSW: CMSSW_15_0_X_2025-02-03-2300/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/47259/44192/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 97 lines from the logs
  • Reco comparison results: 76774 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 4016938
  • DQMHistoTests: Total failures: 477325
  • DQMHistoTests: Total nulls: 301
  • DQMHistoTests: Total successes: 3539292
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 4.671 KiB( 49 files compared)
  • DQMHistoSizes: changed ( 10224.0 ): -0.352 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 13034.0 ): -0.104 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 145.604 ): 0.051 KiB JetMET/SUSYDQM
  • DQMHistoSizes: changed ( 17034.0 ): 0.352 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 250202.181 ): -0.176 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 25202.0 ): -0.098 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 7.3 ): 6.046 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 8.0 ): -1.048 KiB SiStrip/MechanicalView
  • Checked 218 log files, 189 edm output root files, 50 DQM output files
  • TriggerResults: found differences in 16 / 48 workflows

@perrotta
Copy link
Contributor

perrotta commented Feb 5, 2025

+db

  • (Technical, for the test area of CondFormats/JetMETObjects)

@jfernan2
Copy link
Contributor

jfernan2 commented Feb 5, 2025

+1

@aloeliger
Copy link
Contributor

+l1

@gartung
Copy link
Member Author

gartung commented Feb 11, 2025

Sorry, pushed to the wrong branch.

@cmsbuild
Copy link
Contributor

@gartung gartung closed this Feb 13, 2025
@gartung gartung deleted the gartung-gcc13-3-1-warning-fix branch February 13, 2025 17:28
@gartung gartung restored the gartung-gcc13-3-1-warning-fix branch February 13, 2025 17:42
@gartung
Copy link
Member Author

gartung commented Feb 13, 2025

Apparently deleting the branch closes the pull request.

@gartung gartung reopened this Feb 13, 2025
@makortel
Copy link
Contributor

hold

@cmsbuild
Copy link
Contributor

Pull request has been put on hold by @makortel
They need to issue an unhold command to remove the hold state or L1 can unhold it for all

@cmsbuild cmsbuild added the hold label Feb 17, 2025
@makortel
Copy link
Contributor

The array-bounds error was disabled for GCC 13 generally in cms-sw/cmsdist#9685, so I wonder if this (more focused) PR is still needed? @smuzaffar what do you think?

@smuzaffar
Copy link
Contributor

yes this PR is not needed any more.

@makortel
Copy link
Contributor

@cmsbuild, please close

@cmsbuild cmsbuild closed this Feb 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment