Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DQMOffline/Trigger: Remove maybe-unitialized warning/error from gcc 13 build #47323

Conversation

gartung
Copy link
Member

@gartung gartung commented Feb 11, 2025

addresses #47322

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 11, 2025

cms-bot internal usage

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @gartung for master.

It involves the following packages:

  • DQMOffline/Trigger (dqm)

@antoniovagnerini, @cmsbuild, @rseidita can you please review it and eventually sign? Thanks.
@Fedespring, @HuguesBrun, @cericeci, @jhgoh, @missirol, @mmusich, @mtosi, @rociovilar, @trocino this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@gartung
Copy link
Member Author

gartung commented Feb 11, 2025

please test for el8_amd64_gcc13

@cmsbuild
Copy link
Contributor

-1

Failed Tests: Build
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b6d71e/44325/summary.html
COMMIT: 9ffdb9b
CMSSW: CMSSW_15_1_X_2025-02-10-2300/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/47323/44325/install.sh to create a dev area with all the needed externals and cmssw changes.

Build

I found compilation error when building:

/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02876/el8_amd64_gcc13/external/gcc/13.3.1-92b2d78dc343ed2bc93c8eb414ddc9ff/bin/c++ -O3 -pthread -pipe -Werror=main -Werror=pointer-arith -Werror=overlength-strings -Wno-vla -Werror=overflow -std=c++20 -ftree-vectorize -Werror=array-bounds -Werror=format-contains-nul -Werror=type-limits -fvisibility-inlines-hidden -fno-math-errno --param vect-max-version-for-alias-checks=50 -Xassembler --compress-debug-sections -fuse-ld=bfd -march=x86-64-v3 -felide-constructors -fmessage-length=0 -Wall -Wno-non-template-friend -Wno-long-long -Wreturn-type -Wextra -Wpessimizing-move -Wclass-memaccess -Wno-cast-function-type -Wno-unused-but-set-parameter -Wno-ignored-qualifiers -Wno-unused-parameter -Wunused -Wparentheses -Werror=return-type -Werror=missing-braces -Werror=unused-value -Werror=unused-label -Werror=address -Werror=format -Werror=sign-compare -Werror=write-strings -Werror=delete-non-virtual-dtor -Werror=strict-aliasing -Werror=narrowing -Werror=unused-but-set-variable -Werror=reorder -Werror=unused-variable -Werror=conversion-null -Werror=return-local-addr -Wnon-virtual-dtor -Werror=switch -fdiagnostics-show-option -Wno-unused-local-typedefs -Wno-attributes -Wno-psabi -DEIGEN_DONT_PARALLELIZE -DEIGEN_MAX_ALIGN_BYTES=64 -Wno-error=unused-variable -DALPAKA_DEFAULT_HOST_MEMORY_ALIGNMENT=128 -DALPAKA_DISABLE_VENDOR_RNG -DBOOST_DISABLE_ASSERTS -flto=auto -fipa-icf -flto-odr-type-merging -fno-fat-lto-objects -Wodr -shared -Wl,-E    -Wl,-z,defs     tmp/el8_amd64_gcc13/src/DQMServices/Components/plugins/DQMServicesComponentsPlugins/DQMDaqInfo.cc.o tmp/el8_amd64_gcc13/src/DQMServices/Components/plugins/DQMServicesComponentsPlugins/DQMEventInfo.cc.o tmp/el8_amd64_gcc13/src/DQMServices/Components/plugins/DQMServicesComponentsPlugins/DQMFEDIntegrityClient.cc.o tmp/el8_amd64_gcc13/src/DQMServices/Components/plugins/DQMServicesComponentsPlugins/DQMFileSaver.cc.o tmp/el8_amd64_gcc13/src/DQMServices/Components/plugins/DQMServicesComponentsPlugins/DQMGenericClient.cc.o tmp/el8_amd64_gcc13/src/DQMServices/Components/plugins/DQMServicesComponentsPlugins/DQMHarvestingMetadata.cc.o tmp/el8_amd64_gcc13/src/DQMServices/Components/plugins/DQMServicesComponentsPlugins/DQMLumiMonitor.cc.o tmp/el8_amd64_gcc13/src/DQMServices/Components/plugins/DQMServicesComponentsPlugins/DQMMessageLogger.cc.o tmp/el8_amd64_gcc13/src/DQMServices/Components/plugins/DQMServicesComponentsPlugins/DQMMessageLoggerClient.cc.o tmp/el8_amd64_gcc13/src/DQMServices/Components/plugins/DQMServicesComponentsPlugins/DQMProvInfo.cc.o tmp/el8_amd64_gcc13/src/DQMServices/Components/plugins/DQMServicesComponentsPlugins/DQMScalInfo.cc.o tmp/el8_amd64_gcc13/src/DQMServices/Components/plugins/DQMServicesComponentsPlugins/DQMStoreStats.cc.o tmp/el8_amd64_gcc13/src/DQMServices/Components/plugins/DQMServicesComponentsPlugins/EDMtoMEConverter.cc.o tmp/el8_amd64_gcc13/src/DQMServices/Components/plugins/DQMServicesComponentsPlugins/MEtoEDMConverter.cc.o tmp/el8_amd64_gcc13/src/DQMServices/Components/plugins/DQMServicesComponentsPlugins/QualityTester.cc.o -o tmp/el8_amd64_gcc13/src/DQMServices/Components/plugins/DQMServicesComponentsPlugins/libDQMServicesComponentsPlugins.so -Wl,-E -Wl,--hash-style=gnu -Wl,--as-needed -Wl,-z,noexecstack -L/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_15_1_X_2025-02-10-2300/biglib/el8_amd64_gcc13 -L/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_15_1_X_2025-02-10-2300/lib/el8_amd64_gcc13 -L/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02876/el8_amd64_gcc13/cms/cmssw/CMSSW_15_1_X_2025-02-10-2300/biglib/el8_amd64_gcc13 -L/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02876/el8_amd64_gcc13/cms/cmssw/CMSSW_15_1_X_2025-02-10-2300/lib/el8_amd64_gcc13 -L/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02876/el8_amd64_gcc13/cms/cmssw/CMSSW_15_1_X_2025-02-10-2300/external/el8_amd64_gcc13/lib -L/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_15_1_X_2025-02-10-2300/static/el8_amd64_gcc13 -L/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02876/el8_amd64_gcc13/cms/cmssw/CMSSW_15_1_X_2025-02-10-2300/static/el8_amd64_gcc13 -lHLTriggerHLTcore -lCondFormatsHLTObjects -lDataFormatsHLTReco -lDataFormatsL1TParticleFlow -lDataFormatsMETReco -lDataFormatsTauReco -lDataFormatsJetReco -lDataFormatsParticleFlowCandidate -lDataFormatsParticleFlowReco -lDataFormatsEgammaCandidates -lDataFormatsHcalIsolatedTrack -lDataFormatsL1TCorrelator -lDataFormatsL1TMuonPhase2 -lDataFormatsMuonReco -lDataFormatsL1TMuon -lDataFormatsRecoCandidate -lDataFormatsCSCDigi -lDataFormatsEgammaReco -lDataFormatsGsfTrackReco -lDataFormatsVertexReco -lDataFormatsGEMDigi -lDataFormatsTrackReco -lDQMServicesComponents -lDataFormatsGEMRecHit -lDataFormatsTrackCandidate -lDataFormatsTrackerRecHit2D -lL1TriggerL1TGlobal -lDataFormatsCSCRecHit -lDataFormatsDTRecHit -lDataFormatsFTLRecHit -lDataFormatsL1TGlobal -lDataFormatsTrajectorySeed -lEventFilterUtilities -lL1TriggerGlobalTriggerAnalyzer -lDataFormatsL1Trigger -lDataFormatsTrackingRecHit -lDataFormatsL1TrackTrigger -lCondFormatsDataRecord -lDataFormatsTrackerCommon -lGeometryCaloGeometry -lGeometryCommonTopologies -lCondCoreDBOutputService -lCondFormatsL1TObjects -lCondFormatsRunInfo -lDataFormatsBeamSpot -lDataFormatsCaloTowers -lDataFormatsEcalRecHit -lDataFormatsGeometryCommonDetAlgo -lDataFormatsHcalRecHit -lDataFormatsHepMCCandidate -lDataFormatsSiStripCluster -lGeometryRecords -lIOPoolStreamer -lCommonToolsUtilAlgos -lCondCoreCondDB -lCondFormatsAlignmentRecord -lDQMServicesCore -lDataFormatsCandidate -lDataFormatsDTDigi -lDataFormatsEcalDigi -lDataFormatsGeometrySurface -lDataFormatsHcalDigi -lDataFormatsL1GlobalCaloTrigger -lDataFormatsTrajectoryState -lFWCoreSources -lCommonToolsUtils -lDataFormatsCLHEP -lDataFormatsCaloRecHit -lDataFormatsEcalDetId -lDataFormatsForwardDetId -lDataFormatsGeometryVector -lDataFormatsHcalDetId -lDataFormatsL1CaloTrigger -lDataFormatsL1GlobalTrigger -lDataFormatsL1ScoutingRawData -lDataFormatsLuminosity -lDataFormatsMuonDetId -lDataFormatsPhase2TrackerCluster -lDataFormatsSiPixelDetId -lDataFormatsSiStripDetId -lDataFormatsTCDS -lFWCoreCatalog -lFWCoreFramework -lFWCorePrescaleService -lUtilitiesStorageFactory -lCondFormatsCommon -lDataFormatsDetId -lDataFormatsFEDRawData -lDataFormatsHistograms -lDataFormatsL1GlobalMuonTrigger -lDataFormatsMath -lDataFormatsOnlineMetaData -lDataFormatsPhase2TrackerDigi -lDataFormatsScalers -lDataFormatsScouting -lDataFormatsSiPixelCluster -lDataFormatsSiStripDigi -lDataFormatsStreamer -lFWCoreCommon -lFWCoreServiceRegistry -lDataFormatsCommon -lFWCoreParameterSet -lFWCoreMessageLogger -lDataFormatsProvenance -lFWCoreConcurrency -lFWCorePluginManager -lFWCoreReflection -lHeterogeneousCoreAlpakaInterface -lCondFormatsSerialization -lFWCoreUtilities -lFWCoreVersion -lUtilitiesOpenSSL -llcg_CoralCommon -llcg_RelationalAccess -llcg_CoralKernel -llcg_CoralBase -lPhysics -lHist -lMatrix -lGenVector -lMathMore -lTree -lNet -lThread -lboost_filesystem -lMathCore -lRIO -lSmatrix -lboost_program_options -lboost_regex -lboost_serialization -lboost_system -lclasslib -lCore -lboost_thread -lboost_date_time -lCLHEP -lpcre -lbz2 -lcurl -lgsl -lemulator_interface -luuid -lprotobuf -ltbb -ltmeventsetup -ltmtable -ltmxsd -ltmgrammar -ltmutil -lxerces-c -llzma -lz -lzstd -lfmt -lcms-md5 -lopenblas -lssl -lcrypto -lcrypt -ldl -lrt -lstdc++fs -ltinyxml2
/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02876/el8_amd64_gcc13/external/gcc/13.3.1-92b2d78dc343ed2bc93c8eb414ddc9ff/bin/../lib/gcc/x86_64-redhat-linux-gnu/13.3.1/../../../../x86_64-redhat-linux-gnu/bin/ld.bfd: cannot find -lHLTriggerHLTcore: No such file or directory
/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02876/el8_amd64_gcc13/external/gcc/13.3.1-92b2d78dc343ed2bc93c8eb414ddc9ff/bin/../lib/gcc/x86_64-redhat-linux-gnu/13.3.1/../../../../x86_64-redhat-linux-gnu/bin/ld.bfd: cannot find -lCondCoreDBOutputService: No such file or directory
/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02876/el8_amd64_gcc13/external/gcc/13.3.1-92b2d78dc343ed2bc93c8eb414ddc9ff/bin/../lib/gcc/x86_64-redhat-linux-gnu/13.3.1/../../../../x86_64-redhat-linux-gnu/bin/ld.bfd: cannot find -lCondFormatsRunInfo: No such file or directory
/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02876/el8_amd64_gcc13/external/gcc/13.3.1-92b2d78dc343ed2bc93c8eb414ddc9ff/bin/../lib/gcc/x86_64-redhat-linux-gnu/13.3.1/../../../../x86_64-redhat-linux-gnu/bin/ld.bfd: cannot find -lCondCoreCondDB: No such file or directory
collect2: error: ld returned 1 exit status
gmake: *** [tmp/el8_amd64_gcc13/src/DQMServices/Components/plugins/DQMServicesComponentsPlugins/libDQMServicesComponentsPlugins.so] Error 1
Leaving library rule at src/DQMServices/Components/plugins
Entering library rule at DQMServices/Components
>> Compiling  src/DQMServices/Components/src/fillJson.cc
/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02876/el8_amd64_gcc13/external/gcc/13.3.1-92b2d78dc343ed2bc93c8eb414ddc9ff/bin/c++ -c -DCMS_MICRO_ARCH='x86-64-v3' -DGNU_GCC -D_GNU_SOURCE -DTBB_USE_GLIBCXX_VERSION=130301 -DTBB_SUPPRESS_DEPRECATED_MESSAGES -DTBB_PREVIEW_RESUMABLE_TASKS=1 -DTBB_PREVIEW_TASK_GROUP_EXTENSIONS=1 -DBOOST_SPIRIT_THREADSAFE -DPHOENIX_THREADSAFE -DBOOST_MATH_DISABLE_STD_FPCLASSIFY -DBOOST_UUID_RANDOM_PROVIDER_FORCE_POSIX -DCMSSW_GIT_HASH='CMSSW_15_1_X_2025-02-10-2300' -DPROJECT_NAME='CMSSW' -DPROJECT_VERSION='CMSSW_15_1_X_2025-02-10-2300' -Isrc -Ipoison -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02876/el8_amd64_gcc13/cms/cmssw/CMSSW_15_1_X_2025-02-10-2300/src -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02876/el8_amd64_gcc13/external/pcre/8.43-98b91818238e6315baa782c93d2e1a8d/include -isystem/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02876/el8_amd64_gcc13/external/boost/1.80.0-e49913a0c81e5566857a044d12019311/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02876/el8_amd64_gcc13/external/bz2lib/1.0.6-f92c52f66bf6507988f946bd77fb689c/include -isystem/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02876/el8_amd64_gcc13/external/clhep/2.4.7.1-702cdfb6dd16a41af8674f0bf734e863/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02876/el8_amd64_gcc13/external/curl/7.79.0-a23d7bdb483609b91c18e4d97a98c4b0/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02876/el8_amd64_gcc13/external/gsl/2.6-1e2efc87aa19e599c5e55ee8595b7eaf/include -isystem/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02876/el8_amd64_gcc13/external/hls/2019.08-657cc2ffa348096ccbbe675bf0695168/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02876/el8_amd64_gcc13/external/libuuid/2.34-c2b49c79f52c48d7cb42b214bd8f95f6/include -isystem/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02876/el8_amd64_gcc13/lcg/root/6.32.09-11da0cda5a556355c79f5108068d5b1d/include -isystem/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02876/el8_amd64_gcc13/external/tbb/v2021.9.0-d9b11c952f9b99be9506dad33c292ca5/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02876/el8_amd64_gcc13/external/xz/5.2.5-5f1d064218d21615d94b64b937b2e0b3/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02876/el8_amd64_gcc13/external/zlib/1.2.13-31c9b620a337e84039f8c84b7cc46501/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02876/el8_amd64_gcc13/external/zstd/1.5.2-785468ffe092efd94d6c33b022d7c757/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02876/el8_amd64_gcc13/external/eigen/3bb6a48d8c171cf20b5f8e48bfb4e424fbd4f79e-f69c28fbc641f93cf8259f2f47a6ec08/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02876/el8_amd64_gcc13/external/eigen/3bb6a48d8c171cf20b5f8e48bfb4e424fbd4f79e-f69c28fbc641f93cf8259f2f47a6ec08/include/eigen3 -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02876/el8_amd64_gcc13/external/fmt/10.2.1-36fc7f6c79f01f17e1a4b853aff183cd/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02876/el8_amd64_gcc13/external/md5/1.0.0-ea9ab1991fd07bc46b92ce4a79651057/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02876/el8_amd64_gcc13/external/OpenBLAS/0.3.27-b82cdf3e5810569d313c8857a6214285/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02876/el8_amd64_gcc13/external/tinyxml2/6.2.0-f3fb3ad5f8c256e1e42fc6264747acf5/include -O3 -pthread -pipe -Werror=main -Werror=pointer-arith -Werror=overlength-strings -Wno-vla -Werror=overflow -std=c++20 -ftree-vectorize -Werror=array-bounds -Werror=format-contains-nul -Werror=type-limits -fvisibility-inlines-hidden -fno-math-errno --param vect-max-version-for-alias-checks=50 -Xassembler --compress-debug-sections -fuse-ld=bfd -march=x86-64-v3 -felide-constructors -fmessage-length=0 -Wall -Wno-non-template-friend -Wno-long-long -Wreturn-type -Wextra -Wpessimizing-move -Wclass-memaccess -Wno-cast-function-type -Wno-unused-but-set-parameter -Wno-ignored-qualifiers -Wno-unused-parameter -Wunused -Wparentheses -Werror=return-type -Werror=missing-braces -Werror=unused-value -Werror=unused-label -Werror=address -Werror=format -Werror=sign-compare -Werror=write-strings -Werror=delete-non-virtual-dtor -Werror=strict-aliasing -Werror=narrowing -Werror=unused-but-set-variable -Werror=reorder -Werror=unused-variable -Werror=conversion-null -Werror=return-local-addr -Wnon-virtual-dtor -Werror=switch -fdiagnostics-show-option -Wno-unused-local-typedefs -Wno-attributes -Wno-psabi -DEIGEN_DONT_PARALLELIZE -DEIGEN_MAX_ALIGN_BYTES=64 -Wno-error=unused-variable -DBOOST_DISABLE_ASSERTS -flto=auto -fipa-icf -flto-odr-type-merging -fno-fat-lto-objects -Wodr -fPIC -MMD -MF tmp/el8_amd64_gcc13/src/DQMServices/Components/src/DQMServicesComponents/fillJson.cc.d src/DQMServices/Components/src/fillJson.cc -o tmp/el8_amd64_gcc13/src/DQMServices/Components/src/DQMServicesComponents/fillJson.cc.o


@gartung
Copy link
Member Author

gartung commented Feb 13, 2025

please test with #47259 for el8_amd64_gcc13

@gartung
Copy link
Member Author

gartung commented Feb 13, 2025

Incorrectly identified the warning as the source of the build error. Real build error was missing build of Geometry/HGCalTBCommonData package.

@gartung gartung closed this Feb 13, 2025
@gartung gartung deleted the gartung-DQMOffline-trigger-warning-flag-gcc13 branch February 13, 2025 17:02
@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b6d71e/44379/summary.html
COMMIT: 9ffdb9b
CMSSW: CMSSW_15_1_X_2025-02-12-2300/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/47323/44379/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 383 lines from the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 74614 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3905420
  • DQMHistoTests: Total failures: 466972
  • DQMHistoTests: Total nulls: 300
  • DQMHistoTests: Total successes: 3438128
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.827 KiB( 48 files compared)
  • DQMHistoSizes: changed ( 10224.0 ): 0.352 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 13034.0 ): 0.713 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 145.604 ): 0.051 KiB JetMET/SUSYDQM
  • DQMHistoSizes: changed ( 17034.0 ): -5.459 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 250202.181 ): -0.420 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 25202.0 ): 0.592 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 7.3 ): 6.046 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 8.0 ): -1.048 KiB SiStrip/MechanicalView
  • Checked 214 log files, 184 edm output root files, 49 DQM output files
  • TriggerResults: found differences in 15 / 47 workflows

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DQMOffline/Trigger: spurious(?) maybe-uninitialized warning/error in gcc 13 build for STL function
2 participants