Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds Analytics Code to URLs #87

Merged
merged 5 commits into from
Feb 13, 2024
Merged

Adds Analytics Code to URLs #87

merged 5 commits into from
Feb 13, 2024

Conversation

colbyfayock
Copy link
Collaborator

@colbyfayock colbyfayock commented Oct 11, 2023 •
edited
Loading

Description

Appends the analytics codes to the URL for internal analytics

Currently this doesn't support SDK Semver or Tech Version due to being unable to get version imports working without having to manually configure it each time. will open a separate issue to address this

Issue Ticket Number

Fixes #70

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist

  • I have followed the contributing guidelines of this project as mentioned in CONTRIBUTING.md
  • I have created an issue ticket for this PR
  • I have checked to ensure there aren't other open Pull Requests for the same update/change?
  • I have performed a self-review of my own code
  • I have run tests locally to ensure they all pass
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes needed to the documentation

@netlify
Copy link

netlify bot commented Oct 11, 2023 •
edited
Loading

✅ Deploy Preview for netlify-plugin-cloudinary ready!

Name Link
🔨 Latest commit 379483c
🔍 Latest deploy log https://app.netlify.com/sites/netlify-plugin-cloudinary/deploys/65cbe1e7a055d000083027c7
😎 Deploy Preview https://deploy-preview-87--netlify-plugin-cloudinary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@colbyfayock
Copy link
Collaborator Author

@matiasfha - can you give me a hand here?

i want to be able to dynamically set sdkSemver based on the version set in package.json however due to the tsconfig, i'm unable to import the package.json file into the project

the issue appears to be the rootDir config, and i tried googling around on solutions but haven't quite found anything that works yet

i tried to simply lift the rootDir to ./ but that doesn't properly build then

any recommendations? or what additionally i would need to do if we remove rootDir?

@colbyfayock colbyfayock mentioned this pull request Oct 11, 2023
Closed
@colbyfayock
Copy link
Collaborator Author

blocked by cloudinary/cloudinary_npm#634

@colbyfayock colbyfayock merged commit 4940fb0 into main Feb 13, 2024
12 checks passed
@colbyfayock colbyfayock deleted the feat/70-analytics branch February 13, 2024 21:52
github-actions bot pushed a commit that referenced this pull request Feb 13, 2024
@semantic-release-bot
chore(release): 1.17.0 [skip ci]
c514e50 
# [1.17.0](v1.16.0...v1.17.0) (2024-02-13)

### Features

* Adds Analytics Code to URLs ([#87](#87)) ([4940fb0](4940fb0)), closes [#11](#11) [#70](#70)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature] Analytics
1 participant
@colbyfayock