Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support passing in analytics product version to URL generation #634

Closed
colbyfayock opened this issue Oct 11, 2023 · 2 comments
Closed

Support passing in analytics product version to URL generation #634

colbyfayock opened this issue Oct 11, 2023 · 2 comments

Comments

@colbyfayock
Copy link

Currently the SDK doesn't support passing in the product version (A, B, etc) which prevents being able to use this for other packages that need to use a version other than B.

Explain your use case

I'd like to be able to support analytics in Netlify Cloudinary as well as any other integration that makes use of algorithm B.

Netlify Cloudinary reference: cloudinary-community/netlify-plugin-cloudinary#87

Do you have a proposed solution?

The URL Gen SDK supports passing in product alongside sdkCode and sdkSemver

@victorli-cloudinary
Copy link
Contributor

Hey @colbyfayock , looks like this change was included with the 2.0.1 release, could you have a look and confirm if everything is OK on your end?

@colbyfayock
Copy link
Author

just tested it out and it looks like we're good to go. thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants