Verify modules will compile for amd64 #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fredlawl
commented
Mar 15, 2024
fredlawl
commented
Mar 15, 2024
In our builds, we get a message like:
Node.js 16 actions are deprecated. Please update the following actions
to use Node.js 20: actions/checkout@v3, actions/upload-artifact@v3.
And looking at the recent documentation [1] it seems we should update
these to instead @v4.
Link: https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#jobsjob_idstepsuses
Signed-off-by: Frederick Lawler <[email protected]>
fredlawl
force-pushed
the
fred/cf-zeta
branch
2 times, most recently
from
939033a to
90fb5eb
Compare
The user-mode linux architecture compile hides errors we may encounter when actually compiling for release. Therefore, we need to ensure our modules can at least be compiled against amd64. Introduce 3 new steps: 1. make allnoconfig Ensures that we're not introducing anything that would accidentally break a build where nothing is set. 2. make defconfig This is our control build. 3. make defconfig + config-integration This tests that we can do our control + custom options. i.e. enable modules we want to compile. These three tests should be enough to satisfy Intel's testing-bot. We'll skip allyesconfig since that takes a very long time to compile. Lastly, enable "continue-on-error" so that we can see the results for all 3 builds at once and not individually. Signed-off-by: Frederick Lawler <[email protected]>
fredlawl
commented
Mar 15, 2024
| make defconfig | ||
| ./scripts/kconfig/merge_config.sh -m .config config-integration | ||
| make olddefconfig | ||
| make -j$(nproc) > results/config-integration.out 2>&1 |
There was a problem hiding this comment.
In my testing container, I couldn't quite get the make -j$(nproc) > file 2>&1 to work as I wanted it to. I think for now we assume that it is working, because there's no build errors to report anyway for this PR. The artifacts also contain the full build output anyway.
jopelima
approved these changes
Mar 18, 2024
armfazh
approved these changes
Mar 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The user-mode linux architecture compile hides errors we may encounter when actually compiling for release. Therefore, we need to ensure our modules can at least be compiled against amd64.
Introduce 3 new steps:
make allnoconfig
Ensures that we're not introducing anything that would accidentally break a build where nothing is set.
make defconfig
This is our control build.
make defconfig + config-integration
This tests that we can do our control + custom options. i.e. enable modules we want to compile.
These three tests should be enough to satisfy Intel's testing-bot. We'll skip allyesconfig since that takes a very long time to compile. Lastly, enable "continue-on-error" so that we can see the results for all 3 builds at once and not individually.