Skip to content

Commit

Permalink
Verify modules will compile for amd64
Browse files Browse the repository at this point in the history
The user-mode linux architecture compile hides errors we may encounter when
actually compiling for release. Therefore, we need to ensure our modules
can at least be compiled against amd64.

Introduce 3 new steps:

1. make allnoconfig
Ensures that we're not introducing anything that would accidentally break
a build where nothing is set.

2. make defconfig
This is our control build.

3. make defconfig + config-integration
This tests that we can do our control + custom options. i.e. enable
modules we want to compile.

These three tests should be enough to satisfy Intel's testing-bot. We'll skip
allyesconfig since that takes a very long time to compile. Lastly,
enable "continue-on-error" so that we can see the results for all 3
builds at once and not individually.

Signed-off-by: Frederick Lawler <[email protected]>
  • Loading branch information
fredlawl committed Mar 18, 2024
1 parent a5efe5f commit ce8b0f4
Show file tree
Hide file tree
Showing 2 changed files with 38 additions and 0 deletions.
37 changes: 37 additions & 0 deletions .github/workflows/crypto-test-harness.yml
Original file line number Diff line number Diff line change
Expand Up @@ -43,3 +43,40 @@ jobs:
with:
name: tcrypt_job
path: ./tcrypt.out
cfgcheck:
runs-on: ubuntu-22.04
steps:
- name: Install dependencies
run: |
sudo apt-get update
sudo apt-get install -y bc libelf-dev pahole
- name: Checkout
uses: actions/checkout@v4
- name: allnoconfig
continue-on-error: true
run: |
mkdir -p results
make mrproper
make allnoconfig
make -j$(nproc) > results/config-allnoconfig.out 2>&1
- name: defconfig
continue-on-error: true
run: |
make mrproper
make defconfig
make -j$(nproc) > results/config-defconfig.out 2>&1
- name: defconfig + config-integration
continue-on-error: true
run: |
cp zeta/test-artifacts/config-integration .
make mrproper
make defconfig
./scripts/kconfig/merge_config.sh -m .config config-integration
make olddefconfig
make -j$(nproc) > results/config-integration.out 2>&1
- name: Collect artifacts
uses: actions/upload-artifact@v4
if: success() || failure()
with:
name: cfgcheck_job
path: results
1 change: 1 addition & 0 deletions zeta/test-artifacts/config-integration
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
CONFIG_CRYPTO_SHA2_HACL=m

0 comments on commit ce8b0f4

Please sign in to comment.