Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Colors on the map for multistate features #42

Closed
NataliiaHue opened this issue Nov 18, 2022 · 14 comments · Fixed by #62
Closed

Colors on the map for multistate features #42

NataliiaHue opened this issue Nov 18, 2022 · 14 comments · Fixed by #62
Milestone

Comments

@NataliiaHue
Copy link

For multistate features, the colors on the map are green, red and orange, and with alpha (transparency) orange and red look very similar. Would it be possible to use another color instead of orange to make it stand out a little bit more?
If we wanted to take into account that some people don't distinguish green and red, then all these three colors would look the same to them.

@HedvigS
Copy link
Collaborator

HedvigS commented Mar 1, 2023

These colors is an option, that would match the manuscript

  • #593d9cff
  • #f68f46ff
  • #73D055FF

@HedvigS
Copy link
Collaborator

HedvigS commented Mar 28, 2023

@NataliiaHue what do you think?
#50

@NataliiaHue
Copy link
Author

I guess violet will be more distinguishable from orange than red, when made transparent.

@HedvigS
Copy link
Collaborator

HedvigS commented Mar 29, 2023

I guess violet will be more distinguishable from orange than red, when made transparent.

@johenglisch you decide.

In the grambank paper, we use

"#593d9cff"
"#f68f46ff"
"#00c5cdFF"

and this scale:
sample-palette

@johenglisch
Copy link
Contributor

Hm, I think I'm just gonna roll with the current version. The only thing that might potentially cause trouble could be the turquoise and the blue but they only co-occur in two features (GB193 and GB203).

If they do actually end up causing trouble we can always go in later and change the colours, or disable transparency, or go full playstation if we have to. Until then I'd say good enough is good.

@HedvigS HedvigS reopened this May 15, 2023
@HedvigS
Copy link
Collaborator

HedvigS commented May 15, 2023

Claire Bowern said:

Grambank is so cool :) but you know that!
quick (and not urgent) question about map colors - the default green and yellow don't show up that well on slides, particularly on the terrain map options. wals has a way to change things, will that be an option for grambank at some point?

@NataliiaHue
Copy link
Author

will that be an option for grambank at some point?

I don't know, will it be, @johenglisch?

@chirila
Copy link

chirila commented May 15, 2023

The main issue is the binary features don't show up too well on the terrain map, particularly on slides (ie when projected from far away)
Screenshot 2023-05-15 at 2 40 13 PM

@xrotwang
Copy link
Member

Yes, WALS has some functionality to select map markers per feature value. That implementation is somewhat brittle and outdated, though (e.g. it doesn't allow for selecting arbitrary colors, or controlling transparency). A slightly more modern implementation would make use of a tool like coloris, but that would require quite a bit of rewiring and writing hard-to-test UI code.

Since the Grambank data is available as CLDF dataset, I'd rather recommend using tools such as cldfviz to create custom maps with full(er) control over appearance of map markers.

@xrotwang
Copy link
Member

After a bit of experimentation, a solution based on coloris looks workable. To get this working for combined features and trees will still take more work.

@xrotwang
Copy link
Member

@chirila I just pushed a new implementation of marker-customization functionality for WALS, see for example https://wals.info/feature/1A?iconsize=20&labels=0&v1=s0000dda3&v2=d9999ff9e&v3=cffffff9e&v4=tff66ffa0&v5=fdd000087
This functionality could be integrated in Grambank as well. Let me know whether that addresses your issue.

@xrotwang
Copy link
Member

@HedvigS should I go ahead and deploy the marker-selection functionality?

xrotwang added a commit that referenced this issue May 23, 2023
@HedvigS
Copy link
Collaborator

HedvigS commented May 23, 2023

Sure! I don't have strong feelings on this, I trust your judgment on what is the best thing to do here.

xrotwang added a commit that referenced this issue May 23, 2023
@chirila
Copy link

chirila commented May 23, 2023 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants