-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Colors on the map for multistate features #42
Comments
These colors is an option, that would match the manuscript
|
@NataliiaHue what do you think? |
I guess violet will be more distinguishable from orange than red, when made transparent. |
@johenglisch you decide. In the grambank paper, we use "#593d9cff" |
Hm, I think I'm just gonna roll with the current version. The only thing that might potentially cause trouble could be the turquoise and the blue but they only co-occur in two features (GB193 and GB203). If they do actually end up causing trouble we can always go in later and change the colours, or disable transparency, or go full playstation if we have to. Until then I'd say good enough is good. |
Claire Bowern said:
|
I don't know, will it be, @johenglisch? |
Yes, WALS has some functionality to select map markers per feature value. That implementation is somewhat brittle and outdated, though (e.g. it doesn't allow for selecting arbitrary colors, or controlling transparency). A slightly more modern implementation would make use of a tool like coloris, but that would require quite a bit of rewiring and writing hard-to-test UI code. Since the Grambank data is available as CLDF dataset, I'd rather recommend using tools such as cldfviz to create custom maps with full(er) control over appearance of map markers. |
After a bit of experimentation, a solution based on coloris looks workable. To get this working for combined features and trees will still take more work. |
@chirila I just pushed a new implementation of marker-customization functionality for WALS, see for example https://wals.info/feature/1A?iconsize=20&labels=0&v1=s0000dda3&v2=d9999ff9e&v3=cffffff9e&v4=tff66ffa0&v5=fdd000087 |
@HedvigS should I go ahead and deploy the marker-selection functionality? |
Sure! I don't have strong feelings on this, I trust your judgment on what is the best thing to do here. |
Wonderful, many thanks!
…On Mon, May 22, 2023 at 10:38 AM Robert Forkel ***@***.***> wrote:
@chirila <https://github.com/chirila> I just pushed a new implementation
of marker-customization functionality for WALS, see for example
https://wals.info/feature/1A?iconsize=20&labels=0&v1=s0000dda3&v2=d9999ff9e&v3=cffffff9e&v4=tff66ffa0&v5=fdd000087
This functionality could be integrated in Grambank as well. Let me know
whether that addresses your issue.
—
Reply to this email directly, view it on GitHub
<#42 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AD7SQR3QBXKAVWVZ7MUH6ILXHN27DANCNFSM6AAAAAASELIACI>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
--
Claire Bowern
Professor, Director of Undergraduate Studies
Editor: *Diachronica*
Department of Linguistics, Yale University
|
For multistate features, the colors on the map are green, red and orange, and with alpha (transparency) orange and red look very similar. Would it be possible to use another color instead of orange to make it stand out a little bit more?
If we wanted to take into account that some people don't distinguish green and red, then all these three colors would look the same to them.
The text was updated successfully, but these errors were encountered: