Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tree visualisation from D-PLACE #12

Open
SimonGreenhill opened this issue Dec 19, 2019 · 26 comments
Open

Add tree visualisation from D-PLACE #12

SimonGreenhill opened this issue Dec 19, 2019 · 26 comments

Comments

@SimonGreenhill
Copy link

No description provided.

@SimonGreenhill
Copy link
Author

Note: I think we should just do this on glottolog trees at a family level rather than doing what DPLACE does.

@HedvigS
Copy link
Collaborator

HedvigS commented Nov 4, 2021

Loving the tree display in the web app @xrotwang ! Not sure when that happened, but I like it!

Can we make it so that the tips are either language-leveld or the glottocode of the GB dialects? Right now I think it's down to the very end dialect tip of each branch, which for example for Japonic makes it look much larger than if it was viewed by language-leveled tips.

@xrotwang
Copy link
Member

xrotwang commented Nov 8, 2021

What exactly are we talking about? Can you post a link?

@HedvigS
Copy link
Collaborator

HedvigS commented Nov 8, 2021

Sure! Sorry.

At the very bottom of the family pages there's a classification tree from glottolog: https://grambank.clld.org/familys/abkh1242

@HedvigS
Copy link
Collaborator

HedvigS commented Mar 1, 2023

@SimonGreenhill is it a necessity for you that this is in the launch version of the website? If so, we better get a move on on it probably.

@HedvigS
Copy link
Collaborator

HedvigS commented Mar 1, 2023

example from dplace website
Screenshot 2023-03-01 at 12 55 47

@xrotwang
Copy link
Member

xrotwang commented Mar 6, 2023

@johenglisch the feature was implemented for grambank at some point. Here's the relevant commit eb8ad96

@xrotwang xrotwang added this to the Grambank 1.0 milestone Mar 6, 2023
@johenglisch
Copy link
Contributor

Okay, studid question: What is actually left to do for this? I went to

https://grambank.clld.org/familys/indo1319?feature=GB020#3/41.11/49.39

and there's a dropbox for choosing a feature, a map, a table, and a tree. The main difference I can make out is that d-place allows you to show multiple features in the same tree, while Grambank only visualises one.

@HedvigS
Copy link
Collaborator

HedvigS commented Mar 6, 2023

@johenglisch not stupid quesiton, very valid. I didn't know that was there (maybe we should add a statement somewhere saying that this exists?)
@SimonGreenhill are you happy with the current state? Do you want it positioned somewhere else?

@johenglisch
Copy link
Contributor

maybe we should add a statement somewhere saying that this exists?

Hm, maybe, but where?

Currently you can just click on any family in the language table (e.g. https://grambank.clld.org/familys/aust1307) and the family page will prominently show a box at the top. I suppose we could another box like that to the page for an individual feature maybe? (like, right next to the feature combination box)

@HedvigS
Copy link
Collaborator

HedvigS commented Mar 6, 2023

What's the CLLD way of giving an overview of web page functionalities in general?

@HedvigS
Copy link
Collaborator

HedvigS commented Mar 6, 2023

Okay, studid question: What is actually left to do for this? I went to

https://grambank.clld.org/familys/indo1319?feature=GB020#3/41.11/49.39

and there's a dropbox for choosing a feature, a map, a table, and a tree. The main difference I can make out is that d-place allows you to show multiple features in the same tree, while Grambank only visualises one.

wait... how did you get there :)?! I can see the URL, but I haven't yet figured out how to click my way there.

@xrotwang
Copy link
Member

xrotwang commented Mar 6, 2023

There used to be a top-level menu entry linking to the list of covered Glottolog families:
https://grambank.clld.org/familys

@xrotwang
Copy link
Member

xrotwang commented Mar 6, 2023

What's the CLLD way of giving an overview of web page functionalities in general?

The "CLLD way" is sticking to uniformity. The main menu links to lists of core objects in the database. The context menu provides relevant links depending on the visited page.

@HedvigS
Copy link
Collaborator

HedvigS commented Mar 6, 2023

There used to be a top-level menu entry linking to the list of covered Glottolog families: https://grambank.clld.org/familys

Okay. Is the idea to insert that again then?

@HedvigS
Copy link
Collaborator

HedvigS commented Mar 6, 2023

Okay. Thank you for clarifying that, I've actually been a bit confused for a while what the two menus are about.

Where would you like to put a tab that goes to a page that gives a basic overview of the website functions, like the tree, map, combination of features etc?

@xrotwang
Copy link
Member

xrotwang commented Mar 6, 2023

Where would you like to put a tab that goes to a page that gives a basic overview of the website functions, like the tree, map, combination of features etc?

I'd put the content into a template help.mako, which will then picked up by clld and automatically linked from an entry "Help" in the context menu of the landing page. @johenglisch see https://github.com/clld/clld/blob/837351371d150f43c4945140d3ec1f2027375f6a/src/clld/web/app.py#L621

@johenglisch
Copy link
Contributor

how to click my way there

  • Go to grambank
  • Click on Languages and dialects
  • Click on any family in the language table
  • The family page has a box where you can choose a feature and hit submit

This should also work from any place where a language family is clickable (value tables for example).

As for a help page: Yeah, I can set that up the template.

@HedvigS
Copy link
Collaborator

HedvigS commented Mar 7, 2023

how to click my way there

  • Go to grambank
  • Click on Languages and dialects
  • Click on any family in the language table
  • The family page has a box where you can choose a feature and hit submit

This should also work from any place where a language family is clickable (value tables for example).

As for a help page: Yeah, I can set that up the template.

Aha okay, I hadn't spotted that the content in the family column were links at all.

@HedvigS
Copy link
Collaborator

HedvigS commented Mar 7, 2023

Can we put the tree functionality on the feature page view as well?

@SimonGreenhill
Copy link
Author

Looks great, thanks @johenglisch.

  • can we check the character mapping e.g. here the map has two states, but the tree has three?
  • can we make the colors/symbols match with those on the map?

Agree with @HedvigS, can we get it on the feature view page. Perhaps we could have the Map and the Tree in alternate tabs/iframes to save on js load/render (i.e. "show me a map, show me a tree")?

@johenglisch
Copy link
Contributor

the map has two states, but the tree has three

Not sure what you mean: From what I can tell both the map and the tree show three values (four if you include ?).

states

can we make the colors/symbols match with those on the map?

Yeah, good idea. Also, the colours probably shouldn't be orangey red and reddy orange anymore (maybe these: #42 (comment)).

Perhaps we could have the Map and the Tree in alternate tabs/iframes to save on
js load/render

I actually had a simpler solution in mind: A drop box on the feature page that lets you pick a language family and brings you to the page with the tree (maybe right next to the one linking to feature combinations; cf. #44 (comment)).

Then we would have a family page that lets you choose a feature and a feature page that lets you choose a family and they would link to the same tree view. Nice and symmetrical.

@xrotwang
Copy link
Member

xrotwang commented Mar 8, 2023

Then we would have a family page that lets you choose a feature and a feature page that lets you choose a family and they would link to the same tree view. Nice and symmetrical.

Yes, and this page would also be bookmarkable - without relying on URL fragments, etc.

@SimonGreenhill
Copy link
Author

ok, that all sounds good.

Re: colors -- yes, I think I was thrown by the red/orange thing, can we make them consistent to help my eyes?

@johenglisch johenglisch mentioned this issue Mar 28, 2023
@HedvigS
Copy link
Collaborator

HedvigS commented Apr 11, 2023

Looks like this is wrapped up, yeah?

@HedvigS
Copy link
Collaborator

HedvigS commented Jan 9, 2024

@SimonGreenhill can you have a look at #49 ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants