Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow marker selection by users #62

Merged
merged 1 commit into from
May 23, 2023
Merged

allow marker selection by users #62

merged 1 commit into from
May 23, 2023

Conversation

xrotwang
Copy link
Member

closes #42

@xrotwang xrotwang requested a review from johenglisch May 23, 2023 07:53
@johenglisch
Copy link
Contributor

Hm, I tried changing the colours in /parameters/GB020#map-container and the map doesn't seem to update. Maybe the code assigning the default colours is 'too strong' somehow?

@xrotwang
Copy link
Member Author

Did you "shift-reload"? Maybe the clld javascript is cached?

johenglisch
johenglisch approved these changes May 23, 2023
View reviewed changes
Copy link
Contributor

@johenglisch johenglisch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, right, my bad. I had another app open in another window. Yeah, it works like a charm, thanks.

@xrotwang xrotwang merged commit 363967f into master May 23, 2023
@xrotwang xrotwang deleted the marker-select branch May 23, 2023 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johenglisch johenglisch johenglisch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Colors on the map for multistate features
2 participants
@xrotwang @johenglisch