2521 Refactor CVE and Product Info Tables #2526
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Matthew-Grayson
changed the title
…tency; update associated endpoints, tests, and API calls; remove redundant cpe_list column.
Matthew-Grayson
added
Blocked
…tor-cve-and-product_info-tables
Matthew-Grayson
requested review from
rapidray12,
schmelz21,
cduhn17,
aloftus23 and
nickviola
as code owners
Matthew-Grayson
added
Backend
Matthew-Grayson
added
the
Blocked
|
This is difficult to test due to issues calling the PE API today. |
ameliav
reviewed
Feb 13, 2024
…tor-cve-and-product_info-tables
auto-merge was automatically disabled
February 15, 2024 17:42
Pull request was converted to draft
…Db method; separate leftJoinAndSelect() and where() methods to restore cpe/cve endpoint functionality.
|
I've updated syncdb's populate method to include the cve and cpe tables to assist local development. To this PR's changes:
|
Matthew-Grayson
removed
the
Blocked
….onConflict method so that modifiedAt field isn't overwritten with current time, and add skipUpdateIdNotValuesChanged property to reduce inserts. Add optional parameters to CveEntry interface to match response schema from PE endpoint. Add CVE name to console logs.
ameliav
approved these changes
Feb 16, 2024
…ishedAt/modifiedAt columns nullable to match PE API. Minor formating and refactoring.
…ishedAt/modifiedAt columns nullable to match PE API. Minor formating and refactoring.
…m:cisagov/crossfeed into 2521-refactor-cve-and-product_info-tables
schmelz21
approved these changes
Feb 22, 2024
Matthew-Grayson
deleted the
2521-refactor-cve-and-product_info-tables
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗣 Description
💭 Motivation and context
We recently added two tables, cve and product_info. The column names follow a different naming convention than the rest of the codebase. For one thing they use snake case instead of camel case. This makes our API inconsistent and adds confusion to frontend development.
I renamed the product_info table to cpe so that references to entries are more informative: cpe = single entry and cpes is a collection of entries. This isn't the case now with product_info being used as both singular and plural.
I also removed the cpe_list column since there is already a join table between cves and cpes coded into the db model.
Closes issue #2534
Closes issue #2521
🧪 Testing
Modified tests for API functionality. Manually tested Vulnerability Details page.
✅ Pre-approval checklist
in code comments.
to reflect the changes in this PR.
✅ Pre-merge checklist
✅ Post-merge checklist